distributedlog-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (DL-174) Test fail on Windows - Path must start with /
Date Fri, 06 Jan 2017 03:04:58 GMT

    [ https://issues.apache.org/jira/browse/DL-174?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15803342#comment-15803342
] 

ASF GitHub Bot commented on DL-174:
-----------------------------------

GitHub user adamtracymartin opened a pull request:

    https://github.com/apache/incubator-distributedlog/pull/104

    DL-174: added getParent method to Utils to replace usage of File.getParent which changes
/ to \ on Windows

    …ich changes / to \ in Windows.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/adamtracymartin/incubator-distributedlog DL-174

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-distributedlog/pull/104.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #104
    
----
commit ba70dec41ae7cdac839f01048459f7eef893f6f8
Author: adamtracymartin <atmartin@yahoo.com>
Date:   2017-01-06T03:03:01Z

    added getParent method to Utils to replace usage of File.getParent which changes / to
\ in Windows.

----


> Test fail on Windows - Path must start with /
> ---------------------------------------------
>
>                 Key: DL-174
>                 URL: https://issues.apache.org/jira/browse/DL-174
>             Project: DistributedLog
>          Issue Type: Bug
>    Affects Versions: 0.4.0
>            Reporter: Tracy Martin
>            Assignee: Tracy Martin
>            Priority: Minor
>
> When running mvn clean test on Windows, some tests fail with the error "Path must start
with /".
> Example:
> testCheckAndRepairDLNamespace(com.twitter.distributedlog.admin.TestDLCK)  Time elapsed:
1.016 sec  <<< ERROR!
> java.lang.IllegalArgumentException: Path must start with / character
> 	at org.apache.zookeeper.common.PathUtils.validatePath(PathUtils.java:51)
> 	at org.apache.zookeeper.ZooKeeper.getData(ZooKeeper.java:1794)
> 	at org.apache.bookkeeper.zookeeper.ZooKeeperClient.access$3101(ZooKeeperClient.java:71)
> 	at org.apache.bookkeeper.zookeeper.ZooKeeperClient$21.zkRun(ZooKeeperClient.java:1150)
> 	at org.apache.bookkeeper.zookeeper.ZooKeeperClient$ZkRetryRunnable.run(ZooKeeperClient.java:467)
> 	at org.apache.bookkeeper.zookeeper.ZooKeeperClient.getData(ZooKeeperClient.java:1162)
> 	at org.apache.zookeeper.ZooKeeper.getData(ZooKeeper.java:1820)
> 	at org.apache.bookkeeper.zookeeper.ZooKeeperClient.access$3201(ZooKeeperClient.java:71)
> 	at org.apache.bookkeeper.zookeeper.ZooKeeperClient$22.zkRun(ZooKeeperClient.java:1187)
> 	at org.apache.bookkeeper.zookeeper.ZooKeeperClient$ZkRetryRunnable.run(ZooKeeperClient.java:467)
> 	at org.apache.bookkeeper.zookeeper.ZooKeeperClient.getData(ZooKeeperClient.java:1199)
> 	at com.twitter.distributedlog.util.Utils.zkGetData(Utils.java:334)
> 	at com.twitter.distributedlog.impl.metadata.ZKLogStreamMetadataStore.checkLogMetadataPaths(ZKLogStreamMetadataStore.java:348)
> 	at com.twitter.distributedlog.impl.metadata.ZKLogStreamMetadataStore.getLog(ZKLogStreamMetadataStore.java:557)
> 	at com.twitter.distributedlog.impl.metadata.ZKLogStreamMetadataStore.getLog(ZKLogStreamMetadataStore.java:591)
> 	at com.twitter.distributedlog.BKDistributedLogManager.asyncCreateWriteHandler(BKDistributedLogManager.java:361)
> 	at com.twitter.distributedlog.BKDistributedLogManager.createWriteHandler(BKDistributedLogManager.java:356)
> 	at com.twitter.distributedlog.DLMTestUtil.injectLogSegmentWithLastDLSN(DLMTestUtil.java:392)
> 	at com.twitter.distributedlog.admin.TestDLCK.testCheckAndRepairDLNamespace(TestDLCK.java:122)
> 	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> 	at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
> 	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> 	at java.lang.reflect.Method.invoke(Method.java:498)
> 	at org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:44)
> 	at org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:15)
> 	at org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:41)
> 	at org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:20)
> 	at org.junit.internal.runners.statements.FailOnTimeout$1.run(FailOnTimeout.java:28)



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message