distributedlog-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (DL-171) TestAppendOnlyStreamWriter#testPositionUpdatesOnlyAfterWriteCompletionWithoutFsync failed occasionally
Date Thu, 05 Jan 2017 08:58:58 GMT

    [ https://issues.apache.org/jira/browse/DL-171?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15800817#comment-15800817
] 

ASF GitHub Bot commented on DL-171:
-----------------------------------

GitHub user xieliang opened a pull request:

    https://github.com/apache/incubator-distributedlog/pull/98

    DL-171 : adding a short sleep to let the WriteCompleteListener have time to run before
the final position be requested

    once the "writer.write" is done, if "writer.position()" be invoked easier than the WriteCompleteListener
onSuccess callback, due to the "synchronized", the position result will be 0, not the expected
33. we can just add a short sleep to avoid this test issue.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/xieliang/incubator-distributedlog DL-171-Fix-TestAppendOnlyStreamWriter

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-distributedlog/pull/98.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #98
    
----
commit 9de4d177d2c4d41aaaeaa69012be01fa4e0104ad
Author: xieliang <xieliang007@gmail.com>
Date:   2017-01-05T08:56:37Z

    adding a short sleep to let the WriteCompleteListener have time to run before the final
position be requested

----


> TestAppendOnlyStreamWriter#testPositionUpdatesOnlyAfterWriteCompletionWithoutFsync failed
occasionally
> ------------------------------------------------------------------------------------------------------
>
>                 Key: DL-171
>                 URL: https://issues.apache.org/jira/browse/DL-171
>             Project: DistributedLog
>          Issue Type: Bug
>          Components: tests
>    Affects Versions: 0.4.0
>            Reporter: Liang Xie
>            Assignee: Liang Xie
>
> I had seen several failed running, i.g. the latest one: https://builds.apache.org/job/distributedlog-precommit-pullrequest/68/com.twitter$distributedlog-core/testReport/com.twitter.distributedlog/TestAppendOnlyStreamWriter/testPositionUpdatesOnlyAfterWriteCompletionWithoutFsync/
> I can reproduce it after several runnings locally, after diving into the detail, it turn
out that an execution sequence issue: once the "writer.write" be done, if "writer.position()"
be invoked easier than the WriteCompleteListener onSuccess callback,  due to the "synchronized",
the position result will be 0, not the expected 33. we can just add a short sleep to avoid
this test issue.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message