distributedlog-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (DL-23) Move distributedlog build to depend on central maven repo
Date Mon, 12 Sep 2016 04:27:20 GMT

    [ https://issues.apache.org/jira/browse/DL-23?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15483026#comment-15483026
] 

ASF GitHub Bot commented on DL-23:
----------------------------------

GitHub user jiazhai opened a pull request:

    https://github.com/apache/incubator-distributedlog/pull/27

    DL-23: update libthrift version in distributedlog-core (part 1)

    - update libthrift version to 0.9.x and remove scrooge (as the libthrift is only used
for namespace metadata)
    - add generated thrift files under gen-java dir
    - move write proxy related protocol to distributedlog-service-protocol-thrift
    - move thrift related rpc code to distributedlog-client-thrift

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/jiazhai/incubator-distributedlog zhaijia/update_thrift_version

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-distributedlog/pull/27.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #27
    
----
commit 7b51760ae98f3bbccafa7abfb2cd964004850620
Author: jiazhai <zhaijia03@gmail.com>
Date:   2016-09-12T02:35:55Z

    update libthrift version in distributedlog-core
    
    - update libthrift version to 0.9.x and remove scrooge (as the libthrift is only used
for namespace metadata)
    - add generated thrift files under gen-java dir
    - move write proxy related protocol to distributedlog-service-protocol-thrift
    - move thrift related rpc code to distributedlog-client-thrift

----


> Move distributedlog build to depend on central maven repo
> ---------------------------------------------------------
>
>                 Key: DL-23
>                 URL: https://issues.apache.org/jira/browse/DL-23
>             Project: DistributedLog
>          Issue Type: Improvement
>          Components: distributedlog-client, distributedlog-core
>            Reporter: Sijie Guo
>
> Reported https://github.com/twitter/distributedlog/issues/37.
> Currently they are a few dependencies only exists at maven.twttr. There are two major
pieces, one is the finagle-serverset and while the other one is thrift library. The finagle-serverset
is majorly used for service-discovery by distributedlog-client and thrift is used by scrooge
and the rpc wire protocol between client and write proxy.
> There are two options:
> - one is to look for a solution to move those dependencies to central maven repo.
> - the other one is to see if we can make thrift and its service discovery pluginnable.
so we can support both finagle-thrift and gRPC-protobuf. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message