distributedlog-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (DL-37) Add OffsetSequencer
Date Sun, 28 Aug 2016 16:17:20 GMT

    [ https://issues.apache.org/jira/browse/DL-37?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15443687#comment-15443687
] 

ASF GitHub Bot commented on DL-37:
----------------------------------

Github user khurrumnasimm commented on a diff in the pull request:

    https://github.com/apache/incubator-distributedlog/pull/15#discussion_r76534759
  
    --- Diff: distributedlog-service/src/main/java/com/twitter/distributedlog/service/stream/StreamImpl.java
---
    @@ -239,6 +231,12 @@ private DistributedLogManager openLog(String name) throws IOException
{
         // Expensive initialization, only called once per stream.
         @Override
         public void initialize() throws IOException {
    +        try {
    +            sequencer = ReflectionUtils.newInstance(dynConf.getStreamSequencerClass());
    --- End diff --
    
    @leighst I was thinking of making this configured per stream. do you have any better suggestions
on this?


> Add OffsetSequencer
> -------------------
>
>                 Key: DL-37
>                 URL: https://issues.apache.org/jira/browse/DL-37
>             Project: DistributedLog
>          Issue Type: Improvement
>          Components: distributedlog-core, distributedlog-service
>            Reporter: Khurrum Nasim
>            Assignee: Khurrum Nasim
>             Fix For: 0.4.0
>
>
> In order to support kafka like offset, we'd like to introduce an offset sequencer.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message