directory-users mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Emmanuel Lécharny <elecha...@gmail.com>
Subject Re: ApacheDS and commons.io 2.5
Date Tue, 23 Feb 2016 09:10:10 GMT
Le 22/02/16 23:17, Accorsi, Carlo a écrit :
> Hi Folks,
>
> Wondering if the next drop of Apache DS can include and updated dependency for  commons-io
2.5 ?
> Security conscious customer is asking us..
> https://issues.apache.org/jira/browse/IO-487
>
>
> Let me know and I'll create a JIRA if needed. Thanks!
>
Yes, please. That would help us remember to get rid of commons.io.

FTR, here are the places where we use this lib :

API :

./ldap/extras/sp/META-INF/MANIFEST.MF:Import-Package:
org.apache.commons.io;version="2.4",org.apache.commons.l
./ldap/extras/sp/src/main/java/org/apache/directory/api/ldap/sp/JavaStoredProcUtils.java:import
org.apache.commons.io.IOUtils;
./ldap/schema/data/src/test/java/org/apache/directory/api/ldap/schema/extractor/SchemaLdifExtractorTest.java:import
org.apache.commons.io.FileUtils;
./ldap/schema/data/src/test/java/org/apache/directory/api/ldap/schema/loader/LdifSchemaLoaderTest.java:import
org.apache.commons.io.FileUtils;
./ldap/schema/data/src/test/java/org/apache/directory/api/ldap/schema/loader/MatchingRuleTest.java:import
org.apache.commons.io.FileUtils;
./ldap/schema/data/src/test/java/org/apache/directory/api/ldap/schema/loader/SchemaManagerAddTest.java:import
org.apache.commons.io.FileUtils;
./ldap/schema/data/src/test/java/org/apache/directory/api/ldap/schema/loader/SchemaManagerDelTest.java:import
org.apache.commons.io.FileUtils;
./ldap/schema/data/src/test/java/org/apache/directory/api/ldap/schema/loader/SchemaManagerEnableDisableLoadTest.java:import
org.apache.commons.io.FileUtils;
./ldap/schema/data/src/test/java/org/apache/directory/api/ldap/schema/loader/SchemaManagerLoadTest.java:import
org.apache.commons.io.FileUtils;
./ldap/schema/data/src/test/java/org/apache/directory/api/ldap/schema/loader/SchemaManagerLoadWithDepsTest.java:import
org.apache.commons.io.FileUtils;

ApacheDS :

./bulkloader/src/main/java/org/apache/directory/mavibot/btree/MavibotPartitionBuilder.java:import
org.apache.commons.io.FileUtils;
./bulkloader/src/test/java/org/apache/directory/mavibot/btree/MavibotPartitionBuilderTest.java:import
org.apache.commons.io.FileUtils;
./core-annotations/META-INF/MANIFEST.MF:Import-Package:
org.apache.commons.io;version="[1.4,2)",org.apache.direc
./core-annotations/src/main/java/org/apache/directory/server/core/factory/DefaultDirectoryServiceFactory.java:import
org.apache.commons.io.FileUtils;
./core-annotations/src/test/java/org/apache/directory/server/core/factory/DirectoryServiceAnnotationTest.java:import
org.apache.commons.io.FileUtils;
./core-annotations/src/test/java/org/apache/directory/server/core/factory/DirectoryServiceFactoryTest.java:import
org.apache.commons.io.FileUtils;
./core-api/src/main/java/org/apache/directory/server/core/api/CacheService.java:import
org.apache.commons.io.FileUtils;
./core-integ/src/main/java/org/apache/directory/server/core/integ/IntegrationUtils.java:import
org.apache.commons.io.FileUtils;
./core-integ/src/test/java/org/apache/directory/server/core/schema/PartitionSchemaLoaderIT.java:import
org.apache.commons.io.FileUtils;
./jdbm-partition/src/test/java/org/apache/directory/server/core/partition/impl/btree/jdbm/JdbmIndexTest.java:import
org.apache.commons.io.FileUtils;
./jdbm-partition/src/test/java/org/apache/directory/server/core/partition/impl/btree/jdbm/JdbmRdnIndexTest.java:import
org.apache.commons.io.FileUtils;
./jdbm-partition/src/test/java/org/apache/directory/server/core/partition/impl/btree/jdbm/JdbmStoreTest.java:import
org.apache.commons.io.FileUtils;
./kerberos-test/src/test/java/org/apache/directory/server/kerberos/kdc/AbstractKerberosITest.java:import
org.apache.commons.io.FileUtils;
./ldif-partition/src/test/java/org/apache/directory/server/core/partition/ldif/LdifPartitionTest.java:import
org.apache.commons.io.FileUtils;
./mavibot-partition/src/test/java/org/apache/directory/server/core/partition/impl/btree/mavibot/MavibotIndexTest.java:import
org.apache.commons.io.FileUtils;
./mavibot-partition/src/test/java/org/apache/directory/server/core/partition/impl/btree/mavibot/MavibotStoreTest.java:import
org.apache.commons.io.FileUtils;
./server-annotations/src/test/java/org/apache/directory/server/factory/CreateKdcServerAnnotationTest.java:import
org.apache.commons.io.FileUtils;
./server-annotations/src/test/java/org/apache/directory/server/factory/DirectoryServiceAnnotationTest.java:import
org.apache.commons.io.FileUtils;
./server-config/src/test/java/org/apache/directory/server/config/ChangePasswordConfigReaderTest.java:import
org.apache.commons.io.FileUtils;
./server-config/src/test/java/org/apache/directory/server/config/ConfigPartitionReaderTest.java:import
org.apache.commons.io.FileUtils;
./server-config/src/test/java/org/apache/directory/server/config/ConfigWriterTest.java:import
org.apache.commons.io.FileUtils;
./server-config/src/test/java/org/apache/directory/server/config/HttpServerConfigReaderTest.java:import
org.apache.commons.io.FileUtils;
./server-config/src/test/java/org/apache/directory/server/config/KerberosServerConfigReaderTest.java:import
org.apache.commons.io.FileUtils;
./server-config/src/test/java/org/apache/directory/server/config/LdapServerConfigReaderTest.java:import
org.apache.commons.io.FileUtils;
./server-integ/src/test/java/org/apache/directory/server/replication/ClientInitialRefreshIT.java:import
org.apache.commons.io.FileUtils;
./server-integ/src/test/java/org/apache/directory/server/replication/StaleEventLogDetectionIT.java:import
org.apache.commons.io.FileUtils;
./service/src/test/java/org/apache/directory/server/UberJarMainTest.java:import
org.apache.commons.io.FileUtils;
./syncrepl/src/main/java/org/apache/directory/server/syncrepl/SyncreplRunnerUI.java:import
org.apache.commons.io.FileUtils;
./test-framework/src/main/java/org/apache/directory/server/core/integ/CreateDsRule.java:import
org.apache.commons.io.FileUtils;
./test-framework/src/main/java/org/apache/directory/server/core/integ/FrameworkRunner.java:import
org.apache.commons.io.FileUtils;
./xdbm-partition/src/test/java/org/apache/directory/server/xdbm/impl/avl/AvlRdnIndexTest.java:import
org.apache.commons.io.FileUtils;
./xdbm-partition/src/test/java/org/apache/directory/server/xdbm/search/impl/AndCursorTest.java:import
org.apache.commons.io.FileUtils;
./xdbm-partition/src/test/java/org/apache/directory/server/xdbm/search/impl/EqualityTest.java:import
org.apache.commons.io.FileUtils;
./xdbm-partition/src/test/java/org/apache/directory/server/xdbm/search/impl/GreaterEqTest.java:import
org.apache.commons.io.FileUtils;
./xdbm-partition/src/test/java/org/apache/directory/server/xdbm/search/impl/LessEqTest.java:import
org.apache.commons.io.FileUtils;
./xdbm-partition/src/test/java/org/apache/directory/server/xdbm/search/impl/NestedFilterTest.java:import
org.apache.commons.io.FileUtils;
./xdbm-partition/src/test/java/org/apache/directory/server/xdbm/search/impl/NotCursorTest.java:import
org.apache.commons.io.FileUtils;
./xdbm-partition/src/test/java/org/apache/directory/server/xdbm/search/impl/OrCursorTest.java:import
org.apache.commons.io.FileUtils;
./xdbm-partition/src/test/java/org/apache/directory/server/xdbm/search/impl/PresenceTest.java:import
org.apache.commons.io.FileUtils;
./xdbm-partition/src/test/java/org/apache/directory/server/xdbm/search/impl/SubstringTest.java:import
org.apache.commons.io.FileUtils;


As you can see, we only use the FileUtils class, and I'm quite sure qe
are only using the deleteDirectory() method.

I would strongly suggest we simply don't integrate commons.io in the
next version, and instead use the associated code as a utilisy method in
the API.

Mime
View raw message