Mailing-List: contact kerby-help@directory.apache.org; run by ezmlm
Precedence: bulk
Reply-To: kerby@directory.apache.org
To: kerby@directory.apache.org
From: =?UTF-8?Q?Emmanuel_L=c3=a9charny?= <elecharny@gmail.com>
Subject: Questions about the release
Message-ID: <6bdac7ec-15ea-bd9e-6694-48385808d3a9@gmail.com>
Date: Mon, 8 May 2017 06:17:59 +0200
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.12; rv:45.0)
 Gecko/20100101 Thunderbird/45.8.0
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
archived-at: Mon, 08 May 2017 04:18:10 -0000

Hi guys,


I have checked all the modules, and their dependencies. Here is the result :


kerby-all -> test[junit, assertj-core] : OK, no N&L, test

 |

 +-- kerby-common -> [commons.io] : OK, no N&L, Apache
 +-- kerby-pkix -> [slf4j-api], test[slf4j-simple, mockito-core] : Need
to add the slf4j N&L
 +-- kerby-kerb

 |    |

 |    +-- kerb-core -> OK

 |    +-- kerb-common -> [commons.io] : OK, no N&L, Apache
 |    +-- kerb-util -> test[mockito-core] : OK, no N&L, test
 |    +-- kerb-crypto -> OK
 |    +-- kerb-identity -> OK
 |    +-- kerb-identity-test -> test, no N&L
 |    +-- kerb-client -> test[mockito-core]: OK, no N&L, test
 |    +-- kerb-server -> test[slf4j-simple]: OK, no N&L, test
 |    +-- kerb-kdc-test -> test, no N&L
 |    +-- integration-test -> test, no N&L
 |    +-- kerb-admin -> OK
 |    +-- kerb-admin-server -> OK
 |    +-- kerb-simplekdc -> OK
 |    +-- kerb-client-api-all -> OK
 |    +-- kerb-server-api-all -> OK
 +-- kerby-kdc -> [netty-transport, netty-handler, netty-common,
netty-codec, netty-buffer, slf4j-api] : Need to add the slf4j N&L, add
the netty's NOTICE file

 +-- kerby-tool

 |    |

 |    +-- client-tool -> OK
 |    +-- kdc-tool -> OK

 +-- kerby-kdc-test  -> test, no N&L
 +-- kerby-backend

 |    |

 |    +-- ldap-backend -> test[slf4j-simple], OK, no N&L, test
 |    +-- mavibot-backend -> test[slf4j-simple], OK, no N&L, test
 |    +-- json-backend -> [com.google.code.gson], test[slf4j-simple] :
Check the google gson N&L files.
 |    +-- zookeeper-backend-> OK

 +-- kerby-dist

 |    |

 |    +-- kdc-dist -> [netty, gson, slf4j-api, slf4j-log4j12] : Check
the google gson N&L files. need to add the slf4j N&L, add the netty's
NOTICE file
 |    +-- tool-dist-> [slf4j-api, slf4j-log4j12] : Need to add the slf4j N&L

 +-- benchmark -> benchmarks, no N&L
 +-- kerby-provider

      |

      +- token-provider -> [nimbus-jose-jwt] -> check the
nimbus-jose-jwt N&L


AFAICT, there are not that many missing bits, but there is one more step
to complete : check the transitive depndencies.

Running mvn dependency:tree on modules which have external dependencies
should give the required informations. Typically, on token-provider,
here is what it gives :


MacBook-Pro:token-provider elecharny$ mvn dependency:tree
Java HotSpot(TM) 64-Bit Server VM warning: ignoring option
MaxPermSize=256M; support was removed in 8.0
[INFO] Scanning for projects...
[INFO]                                                                        

[INFO]
------------------------------------------------------------------------
[INFO] Building Token provider 1.0.0
[INFO]
------------------------------------------------------------------------
[INFO]
[INFO] --- maven-dependency-plugin:2.10:tree (default-cli) @
token-provider ---
[INFO] org.apache.kerby:token-provider:jar:1.0.0
[INFO] +- org.apache.kerby:kerb-core:jar:1.0.0:compile
[INFO] |  \- org.apache.kerby:kerby-pkix:jar:1.0.0:compile
[INFO] |     +- org.apache.kerby:kerby-asn1:jar:1.0.0:compile
[INFO] |     +- org.apache.kerby:kerby-util:jar:1.0.0:compile
[INFO] |     \- org.slf4j:slf4j-api:jar:1.7.25:compile
[INFO] +- com.nimbusds:nimbus-jose-jwt:jar:3.10:compile
[INFO] |  +- net.jcip:jcip-annotations:jar:1.0:compile
[INFO] |  +- net.minidev:json-smart:jar:1.3.1:compile
[INFO] |  +- org.bouncycastle:bcprov-jdk15on:jar:1.52:compile
[INFO] |  \- commons-io:commons-io:jar:2.4:compile
[INFO] +- junit:junit:jar:4.12:test
[INFO] |  \- org.hamcrest:hamcrest-core:jar:1.3:test
[INFO] \- org.assertj:assertj-core:jar:2.6.0:test
[INFO]
------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO]
------------------------------------------------------------------------
[INFO] Total time: 1.527 s
[INFO] Finished at: 2017-05-08T06:14:52+02:00
[INFO] Final Memory: 15M/247M
[INFO]
------------------------------------------------------------------------


As we can see, nimbus-jose-jwt has itself some dependencies that
requires some N&L (potentially, that has to be checked) :
jcip-annotations, json-smart and bcprov-jdk15on. If nimbus-jose-jwt has
done its job properly, its N&L files should already contain the required
bits, but we must check.


This tas has to be ran on all the modules that have noapache and
non-tests dependencies...


-- 
Emmanuel Lecharny

Symas.com
directory.apache.org