Mailing-List: contact kerby-help@directory.apache.org; run by ezmlm
Precedence: bulk
Reply-To: kerby@directory.apache.org
From: "Li, Jiajia" <jiajia.li@intel.com>
To: "kerby@directory.apache.org" <kerby@directory.apache.org>
Subject: RE: About KdcRequest
Thread-Topic: About KdcRequest
Thread-Index: AdFKghrKH104eAyhTEe8v0bPWybbVgAAHfjwAGFxTKA=
Date: Mon, 11 Jan 2016 00:41:37 +0000
Message-ID: 
 <9037BCED616A964EB486B12FCA9DCFCF031664D3@SHSMSX103.ccr.corp.intel.com>
References: 
 <8D5F7E3237B3ED47B84CF187BB17B6661485B03A@SHSMSX103.ccr.corp.intel.com>
 <8D5F7E3237B3ED47B84CF187BB17B6661485B055@SHSMSX103.ccr.corp.intel.com>
In-Reply-To: 
 <8D5F7E3237B3ED47B84CF187BB17B6661485B055@SHSMSX103.ccr.corp.intel.com>
Accept-Language: zh-CN, en-US
Content-Language: en-US
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0

Hi Kai,
Thanks for your advises, I will try to refactor the code.

Thanks
Jiajia

-----Original Message-----
From: Zheng, Kai [mailto:kai.zheng@intel.com]=20
Sent: Saturday, January 09, 2016 10:14 AM
To: kerby@directory.apache.org
Subject: RE: About KdcRequest

By the way, DhClient/DhServer would be better renamed. How about DiffieHell=
manClient/DiffieHellmanServer? Still, the "client/server" isn't good but an=
y idea? Thanks.

-----Original Message-----
From: Zheng, Kai [mailto:kai.zheng@intel.com]=20
Sent: Saturday, January 09, 2016 10:08 AM
To: kerby@directory.apache.org
Subject: About KdcRequest

Hi Jiajia,

I noticed the following line and related codes in KdcRequest.

private DhClient dhClient;

In my understanding, it should be only for PKINIT in DH case. Would you min=
d refactoring the codes and moving them to the mechanism specific scope (be=
tter to be in PkinitPreauth plugin). Thanks.

Regards,
Kai