directory-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Colm O hEigeartaigh (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (DIRKRB-717) Allow semicolon as a comment character in krb5.conf files
Date Fri, 27 Jul 2018 11:17:00 GMT

    [ https://issues.apache.org/jira/browse/DIRKRB-717?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16559590#comment-16559590
] 

Colm O hEigeartaigh commented on DIRKRB-717:
--------------------------------------------

For the record, it seems to handle whitespace correctly - I've added some tests.

> Allow semicolon as a comment character in krb5.conf files
> ---------------------------------------------------------
>
>                 Key: DIRKRB-717
>                 URL: https://issues.apache.org/jira/browse/DIRKRB-717
>             Project: Directory Kerberos
>          Issue Type: Sub-task
>            Reporter: Kamil Krynicki
>            Priority: Major
>             Fix For: 1.0.2, 1.1.2
>
>         Attachments: DIRKRB-717_semicolon_as_a_comment_starter.7z
>
>
> I've recently been trying to work with krb5.conf files using kerby and it kept on crashing
when ";" was used as a comment character in the krb5.conf file.
>  
> According to the MIT code:
> [https://github.com/krb5/krb5/blob/0744026f06e8cbf477aa49cfe16b5fd28a9ddc9e/src/util/profile/prof_parse.c#L86]
> it should be allowed.
>  
> While Kerby does this:
> [https://github.com/apache/directory-kerby/blob/trunk/kerby-kerb/kerb-common/src/main/java/org/apache/kerby/kerberos/kerb/common/Krb5Parser.java#L195]
>  
> We should skip lines that start with ';'
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message