From dev-return-57645-archive-asf-public=cust-asf.ponee.io@directory.apache.org Fri Jun 1 10:37:05 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id BAB71180676 for ; Fri, 1 Jun 2018 10:37:04 +0200 (CEST) Received: (qmail 97068 invoked by uid 500); 1 Jun 2018 08:37:03 -0000 Mailing-List: contact dev-help@directory.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: "Apache Directory Developers List" Delivered-To: mailing list dev@directory.apache.org Received: (qmail 96559 invoked by uid 99); 1 Jun 2018 08:37:03 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd2-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 01 Jun 2018 08:37:03 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd2-us-west.apache.org (ASF Mail Server at spamd2-us-west.apache.org) with ESMTP id 197561A3D41 for ; Fri, 1 Jun 2018 08:37:03 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd2-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -109.501 X-Spam-Level: X-Spam-Status: No, score=-109.501 tagged_above=-999 required=6.31 tests=[ENV_AND_HDR_SPF_MATCH=-0.5, KAM_ASCII_DIVIDERS=0.8, RCVD_IN_DNSWL_MED=-2.3, SPF_PASS=-0.001, USER_IN_DEF_SPF_WL=-7.5, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd2-us-west.apache.org [10.40.0.9]) (amavisd-new, port 10024) with ESMTP id PCourjBzmULS for ; Fri, 1 Jun 2018 08:37:02 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id F137B5F57E for ; Fri, 1 Jun 2018 08:37:00 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 6E23BE092E for ; Fri, 1 Jun 2018 08:37:00 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 287AE2108B for ; Fri, 1 Jun 2018 08:37:00 +0000 (UTC) Date: Fri, 1 Jun 2018 08:37:00 +0000 (UTC) From: "Colm O hEigeartaigh (JIRA)" To: dev@directory.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (DIRKRB-717) Allow semicolon as a comment character in krb5.conf files MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/DIRKRB-717?page=3Dcom.atlassian= .jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=3D1649= 7728#comment-16497728 ]=20 Colm O hEigeartaigh commented on DIRKRB-717: -------------------------------------------- Yes please open a separate Jira for that. > Allow semicolon as a comment character in krb5.conf files > --------------------------------------------------------- > > Key: DIRKRB-717 > URL: https://issues.apache.org/jira/browse/DIRKRB-717 > Project: Directory Kerberos > Issue Type: Sub-task > Reporter: Kamil Krynicki > Priority: Major > Fix For: 1.0.2, 1.1.2 > > Attachments: DIRKRB-717_semicolon_as_a_comment_starter.7z > > > I've recently been trying to work with krb5.conf files using kerby and it= kept on crashing when ";" was used as a comment character in the krb5.conf= file. > =C2=A0 > According to the MIT code: > [https://github.com/krb5/krb5/blob/0744026f06e8cbf477aa49cfe16b5fd28a9ddc= 9e/src/util/profile/prof_parse.c#L86] > it should be allowed. > =C2=A0 > While Kerby does this: > [https://github.com/apache/directory-kerby/blob/trunk/kerby-kerb/kerb-com= mon/src/main/java/org/apache/kerby/kerberos/kerb/common/Krb5Parser.java#L19= 5] > =C2=A0 > We should skip lines that start with ';' > =C2=A0 -- This message was sent by Atlassian JIRA (v7.6.3#76005)