Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 7419A200D3A for ; Wed, 15 Nov 2017 20:30:56 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id 72D3E160BF6; Wed, 15 Nov 2017 19:30:56 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 91AC4160BE4 for ; Wed, 15 Nov 2017 20:30:55 +0100 (CET) Received: (qmail 98683 invoked by uid 500); 15 Nov 2017 19:30:46 -0000 Mailing-List: contact dev-help@directory.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: "Apache Directory Developers List" Delivered-To: mailing list dev@directory.apache.org Received: (qmail 98593 invoked by uid 99); 15 Nov 2017 19:30:46 -0000 Received: from mail-relay.apache.org (HELO mail-relay.apache.org) (140.211.11.15) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 15 Nov 2017 19:30:46 +0000 Received: from [192.168.1.212] (c-67-164-129-248.hsd1.nm.comcast.net [67.164.129.248]) by mail-relay.apache.org (ASF Mail Server at mail-relay.apache.org) with ESMTPSA id 3176D1A015A; Wed, 15 Nov 2017 19:30:44 +0000 (UTC) From: Gerard Gagliano Message-Id: Content-Type: multipart/alternative; boundary="Apple-Mail=_35BB1FB6-4C63-458A-8FEF-5F2D548628EA" Mime-Version: 1.0 (Mac OS X Mail 11.1 \(3445.4.7\)) Date: Wed, 15 Nov 2017 12:30:43 -0700 Subject: Re: [jira] [Commented] (DIRKRB-669) Authorization data needed by backend code create a circular project reference In-Reply-To: To: Apache Directory Developers List References: <85F9BD18-06D8-4DC9-8442-9D4B29FB0E6B@apache.org> X-Mailer: Apple Mail (2.3445.4.7) archived-at: Wed, 15 Nov 2017 19:30:56 -0000 --Apple-Mail=_35BB1FB6-4C63-458A-8FEF-5F2D548628EA Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=utf-8 It appears as though the problem with the patch is that it includes a = fix for the file directory-kerby/pom.xml Line 247 in that file is incorrect and made it impossible to compile = under Eclipse. The version specified should be 1.0.0 NOT = 1.0.0-SNAPSHOT. The patch is rejected when that file is included. I have removed it and = posted a new patch. > On Nov 15, 2017, at 7:45 AM, Colm O hEigeartaigh = wrote: >=20 > Thanks, that's the correct commit. Could you update the JIRA with the = more recent patch? Can you apply your own patch via "git apply"? >=20 > Colm. >=20 > On Wed, Nov 15, 2017 at 1:31 PM, Gerard Gagliano > wrote: > Colm, >=20 > I don=E2=80=99t know if this is something you still want since the = comment was deleted. >=20 > The last commit I see in my IDE is: >=20 > commit 1e6d36497a9509294f30c60a214f1a13f81957b1 > Author: plusplusjiajia > 2017-11-14 00:23:40 > Committer: plusplusjiajia > 2017-11-14 00:23:40 > Parent: c64cdefc963cb814d1c7b9d64a2f8e0d6cc7d130 (DIRKRB-668 Enable = KDC backend connect to the HA Zookeeper Cluster. Contributed by = cclive1601.) > Branches: trunk, origin/trunk >=20 > DIRKRB-670 Add checksum verification in TgsRequest. >=20 > > On Nov 15, 2017, at 4:26 AM, Colm O hEigeartaigh (JIRA) = > wrote: > > > > > > [ = https://issues.apache.org/jira/browse/DIRKRB-669?page=3Dcom.atlassian.jira= .plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=3D16253312= #comment-16253312 = ] > > > > Colm O hEigeartaigh commented on DIRKRB-669: > > -------------------------------------------- > > > > The patch still doesn't apply for me. What is the latest commit you = see when you do "git log"? > > > >> Authorization data needed by backend code create a circular project = reference > >> = --------------------------------------------------------------------------= --- > >> > >> Key: DIRKRB-669 > >> URL: = https://issues.apache.org/jira/browse/DIRKRB-669 = > >> Project: Directory Kerberos > >> Issue Type: Improvement > >> Reporter: Gerard Gagliano > >> Assignee: Gerard Gagliano > >> Attachments: KrbClient.patch > >> > >> > >> Making changes necessitated by the introduction of the = KdcClientRequest class and the associated calling parameter changes has = presented a circular reference in kerb-core and krb-identity. > >> Many data items needed by the authorization data backend code are = not included in the KdcClientRequest class as defined in the = 1.1.0-SNAPSHOT. Modification of this class to include the necessary = data items includes a reference to the KrbIdentity class. > >> This creates a circular dependency between the kerb-core project = and the kerb-identity project. The circular dependency can be resolved = by moving KrbIdentity from kerb-identity to kerb-common. At the same = time, KdcClientRequest can be moved to the same location because its = current location (=E2=80=A6.kerb.type.kdc) includes only ASN1 classes. > >> Moving the classes as follows resolves the circular dependency: > >> KdcClientRequest from kerb-core, and > >> KrbIdentity from kerb-identity > >> To kerb-common =E2=80=94 package = org.apache.kerby.kerberos.kerb.request > > > > > > > > -- > > This message was sent by Atlassian JIRA > > (v6.4.14#64029) >=20 >=20 >=20 >=20 > --=20 > Colm O hEigeartaigh >=20 > Talend Community Coder > http://coders.talend.com --Apple-Mail=_35BB1FB6-4C63-458A-8FEF-5F2D548628EA Content-Transfer-Encoding: quoted-printable Content-Type: text/html; charset=utf-8
It appears as though the problem with the patch is that = it includes a fix for the file directory-kerby/pom.xml

Line 247 in that file is incorrect and made it = impossible to compile under Eclipse.  The version specified should = be 1.0.0 NOT 1.0.0-SNAPSHOT.

The = patch is rejected when that file is included.  I have removed it = and posted a new patch.


On Nov = 15, 2017, at 7:45 AM, Colm O hEigeartaigh <coheigea@apache.org>= wrote:

Thanks, that's the correct = commit. Could you update the JIRA with the more recent patch? Can you = apply your own patch via "git apply"?

Colm.

On Wed, Nov 15, 2017 at 1:31 PM, = Gerard Gagliano <gg@apache.org> wrote:
Colm,

I don=E2=80=99t know if this is something you still want since the = comment was deleted.

The last commit I see in my IDE is:

commit 1e6d36497a9509294f30c60a214f1a13f81957b1
Author: plusplusjiajia <jiajia.li@intel.com> 2017-11-14 00:23:40
Committer: plusplusjiajia <jiajia.li@intel.com> 2017-11-14 00:23:40
Parent: c64cdefc963cb814d1c7b9d64a2f8e0d6cc7d130 = (DIRKRB-668 Enable KDC backend connect to the HA Zookeeper Cluster. = Contributed by cclive1601.)
Branches: trunk, origin/trunk

DIRKRB-670 Add checksum verification in TgsRequest.

> On Nov 15, 2017, at 4:26 AM, Colm O hEigeartaigh (JIRA) <jira@apache.org> = wrote:
>
>
>    [ https://issues.apache.org/jira/browse/DIRKRB-669?page=3Dcom.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=3D16253312#comment-16253312 ]
>
> Colm O hEigeartaigh commented on DIRKRB-669:
> --------------------------------------------
>
> The patch still doesn't apply for me. What is the latest commit you = see when you do "git log"?
>
>> Authorization data needed by backend code create a circular = project reference
>> -----------------------------------------------------------------------------
>>
>>                Key: = DIRKRB-669
>>                URL: https://issues.apache.org/jira/browse/DIRKRB-669
>>            Project: Directory = Kerberos
>>         Issue Type: Improvement
>>           Reporter: Gerard = Gagliano
>>           Assignee: Gerard = Gagliano
>>        Attachments: KrbClient.patch
>>
>>
>> Making changes necessitated by the introduction of the = KdcClientRequest class and the associated calling parameter changes has = presented a circular reference in kerb-core and krb-identity.
>> Many data items needed by the authorization data backend code = are not included in the KdcClientRequest class as defined in the = 1.1.0-SNAPSHOT.  Modification of this class to include the = necessary data items includes a reference to the KrbIdentity class.
>> This creates a circular dependency between the kerb-core = project and the kerb-identity project.  The circular dependency can = be resolved by moving KrbIdentity from kerb-identity to = kerb-common.  At the same time, KdcClientRequest can be moved to = the same location because its current location (=E2=80=A6.kerb.type.kdc) = includes only ASN1 classes.
>> Moving the classes as follows resolves the circular = dependency:
>>   KdcClientRequest from kerb-core, and
>>   KrbIdentity from kerb-identity
>>   To kerb-common =E2=80=94 package = org.apache.kerby.kerberos.kerb.request
>
>
>
> --
> This message was sent by Atlassian JIRA
> (v6.4.14#64029)




--
Colm O hEigeartaigh

Talend Community Coder
http://coders.talend.com

= --Apple-Mail=_35BB1FB6-4C63-458A-8FEF-5F2D548628EA--