Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 0BE21200D3A for ; Wed, 15 Nov 2017 15:45:29 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id 09F40160BF4; Wed, 15 Nov 2017 14:45:29 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 30DE6160BEA for ; Wed, 15 Nov 2017 15:45:28 +0100 (CET) Received: (qmail 59192 invoked by uid 500); 15 Nov 2017 14:45:27 -0000 Mailing-List: contact dev-help@directory.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: "Apache Directory Developers List" Delivered-To: mailing list dev@directory.apache.org Received: (qmail 59182 invoked by uid 99); 15 Nov 2017 14:45:27 -0000 Received: from mail-relay.apache.org (HELO mail-relay.apache.org) (140.211.11.15) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 15 Nov 2017 14:45:27 +0000 Received: from mail-pg0-f43.google.com (mail-pg0-f43.google.com [74.125.83.43]) by mail-relay.apache.org (ASF Mail Server at mail-relay.apache.org) with ESMTPSA id D01FB1A015A for ; Wed, 15 Nov 2017 14:45:26 +0000 (UTC) Received: by mail-pg0-f43.google.com with SMTP id z184so12766358pgd.13 for ; Wed, 15 Nov 2017 06:45:26 -0800 (PST) X-Gm-Message-State: AJaThX5H4VuVDtot9WuJqxhetzSoJJhi8vXWuoFTwD2/PmqElqNrVdLU r0BmQC0PIhZDeQ8v4J9ORvaF1PBx3ZNm2LZWJLY= X-Google-Smtp-Source: AGs4zMYfLgq/KenSIw7GW5meihqgmWDrPtePerpEYwagVUdMCkEfcoEYuJLEN+LP9An9r9zLJufnpTMTKWK4h79jwiE= X-Received: by 10.99.121.9 with SMTP id u9mr15982002pgc.37.1510757126110; Wed, 15 Nov 2017 06:45:26 -0800 (PST) MIME-Version: 1.0 Reply-To: coheigea@apache.org Received: by 10.100.166.65 with HTTP; Wed, 15 Nov 2017 06:45:25 -0800 (PST) In-Reply-To: <85F9BD18-06D8-4DC9-8442-9D4B29FB0E6B@apache.org> References: <85F9BD18-06D8-4DC9-8442-9D4B29FB0E6B@apache.org> From: Colm O hEigeartaigh Date: Wed, 15 Nov 2017 14:45:25 +0000 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [jira] [Commented] (DIRKRB-669) Authorization data needed by backend code create a circular project reference To: Apache Directory Developers List Content-Type: multipart/alternative; boundary="94eb2c1932cad80699055e068df4" archived-at: Wed, 15 Nov 2017 14:45:29 -0000 --94eb2c1932cad80699055e068df4 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Thanks, that's the correct commit. Could you update the JIRA with the more recent patch? Can you apply your own patch via "git apply"? Colm. On Wed, Nov 15, 2017 at 1:31 PM, Gerard Gagliano wrote: > Colm, > > I don=E2=80=99t know if this is something you still want since the commen= t was > deleted. > > The last commit I see in my IDE is: > > commit 1e6d36497a9509294f30c60a214f1a13f81957b1 > Author: plusplusjiajia 2017-11-14 00:23:40 > Committer: plusplusjiajia 2017-11-14 00:23:40 > Parent: c64cdefc963cb814d1c7b9d64a2f8e0d6cc7d130 (DIRKRB-668 Enable KDC > backend connect to the HA Zookeeper Cluster. Contributed by cclive1601.) > Branches: trunk, origin/trunk > > DIRKRB-670 Add checksum verification in TgsRequest. > > > On Nov 15, 2017, at 4:26 AM, Colm O hEigeartaigh (JIRA) > wrote: > > > > > > [ https://issues.apache.org/jira/browse/DIRKRB-669?page=3D > com.atlassian.jira.plugin.system.issuetabpanels:comment- > tabpanel&focusedCommentId=3D16253312#comment-16253312 ] > > > > Colm O hEigeartaigh commented on DIRKRB-669: > > -------------------------------------------- > > > > The patch still doesn't apply for me. What is the latest commit you see > when you do "git log"? > > > >> Authorization data needed by backend code create a circular project > reference > >> ------------------------------------------------------------ > ----------------- > >> > >> Key: DIRKRB-669 > >> URL: https://issues.apache.org/jira/browse/DIRKRB-669 > >> Project: Directory Kerberos > >> Issue Type: Improvement > >> Reporter: Gerard Gagliano > >> Assignee: Gerard Gagliano > >> Attachments: KrbClient.patch > >> > >> > >> Making changes necessitated by the introduction of the KdcClientReques= t > class and the associated calling parameter changes has presented a circul= ar > reference in kerb-core and krb-identity. > >> Many data items needed by the authorization data backend code are not > included in the KdcClientRequest class as defined in the 1.1.0-SNAPSHOT. > Modification of this class to include the necessary data items includes a > reference to the KrbIdentity class. > >> This creates a circular dependency between the kerb-core project and > the kerb-identity project. The circular dependency can be resolved by > moving KrbIdentity from kerb-identity to kerb-common. At the same time, > KdcClientRequest can be moved to the same location because its current > location (=E2=80=A6.kerb.type.kdc) includes only ASN1 classes. > >> Moving the classes as follows resolves the circular dependency: > >> KdcClientRequest from kerb-core, and > >> KrbIdentity from kerb-identity > >> To kerb-common =E2=80=94 package org.apache.kerby.kerberos.kerb.requ= est > > > > > > > > -- > > This message was sent by Atlassian JIRA > > (v6.4.14#64029) > > --=20 Colm O hEigeartaigh Talend Community Coder http://coders.talend.com --94eb2c1932cad80699055e068df4 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Thanks, that's the correct commit. Could you upda= te the JIRA with the more recent patch? Can you apply your own patch via &q= uot;git apply"?

Colm.

On Wed, Nov 15, 2017 at 1:31 PM, Gerard Gag= liano <gg@apache.org> wrote:
C= olm,

I don=E2=80=99t know if this is something you still want since the comment = was deleted.

The last commit I see in my IDE is:

commit 1e6d36497a9509294f30c60a214f1a13f81957b1
Author: plusplusjiajia <jiajia.li= @intel.com> 2017-11-14 00:23:40
Committer: plusplusjiajia <jiajia= .li@intel.com> 2017-11-14 00:23:40
Parent: c64cdefc963cb814d1c7b9d64a2f8e0d6cc7d130 (DIRKRB-668 Enable KD= C backend connect to the HA Zookeeper Cluster. Contributed by cclive1601.)<= br> Branches: trunk, origin/trunk

DIRKRB-670 Add checksum verification in TgsRequest.

> On Nov 15, 2017, at 4:26 AM, Colm O hEigeartaigh (JIRA) <jira@apache.org> wrote:
>
>
>=C2=A0 =C2=A0 [ https://issues.apache.org/jira/browse/DIRKRB-669?page=3D= com.atlassian.jira.plugin.system.issuetabpanels:comment-tabp= anel&focusedCommentId=3D16253312#comment-16253312 ]
>
> Colm O hEigeartaigh commented on DIRKRB-669:
> --------------------------------------------
>
> The patch still doesn't apply for me. What is the latest commit yo= u see when you do "git log"?
>
>> Authorization data needed by backend code create a circular projec= t reference
>> ------------------------------------------------------------<= wbr>-----------------
>>
>>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 Key: DIRKRB= -669
>>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 URL: https://issues.apache.org/jira/browse/DIRKRB-669<= br> >>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 Project: Directory Kerber= os
>>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0Issue Type: Improvement
>>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0Reporter: Gerard Gagliano<= br> >>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0Assignee: Gerard Gagliano<= br> >>=C2=A0 =C2=A0 =C2=A0 =C2=A0 Attachments: KrbClient.patch
>>
>>
>> Making changes necessitated by the introduction of the KdcClientRe= quest class and the associated calling parameter changes has presented a ci= rcular reference in kerb-core and krb-identity.
>> Many data items needed by the authorization data backend code are = not included in the KdcClientRequest class as defined in the 1.1.0-SNAPSHOT= .=C2=A0 Modification of this class to include the necessary data items incl= udes a reference to the KrbIdentity class.
>> This creates a circular dependency between the kerb-core project a= nd the kerb-identity project.=C2=A0 The circular dependency can be resolved= by moving KrbIdentity from kerb-identity to kerb-common.=C2=A0 At the same= time, KdcClientRequest can be moved to the same location because its curre= nt location (=E2=80=A6.kerb.type.kdc) includes only ASN1 classes.
>> Moving the classes as follows resolves the circular dependency: >>=C2=A0 =C2=A0KdcClientRequest from kerb-core, and
>>=C2=A0 =C2=A0KrbIdentity from kerb-identity
>>=C2=A0 =C2=A0To kerb-common =E2=80=94 package org.apache.kerby.kerb= eros.kerb.request
>
>
>
> --
> This message was sent by Atlassian JIRA
> (v6.4.14#64029)




--
Colm O hEige= artaigh

Talend Community Coder
http://coders.talend.com
--94eb2c1932cad80699055e068df4--