directory-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Gerard Gagliano ...@apache.org>
Subject Re: [jira] [Commented] (DIRKRB-669) Authorization data needed by backend code create a circular project reference
Date Wed, 15 Nov 2017 19:30:43 GMT
It appears as though the problem with the patch is that it includes a fix for the file directory-kerby/pom.xml

Line 247 in that file is incorrect and made it impossible to compile under Eclipse.  The version
specified should be 1.0.0 NOT 1.0.0-SNAPSHOT.

The patch is rejected when that file is included.  I have removed it and posted a new patch.


> On Nov 15, 2017, at 7:45 AM, Colm O hEigeartaigh <coheigea@apache.org> wrote:
> 
> Thanks, that's the correct commit. Could you update the JIRA with the more recent patch?
Can you apply your own patch via "git apply"?
> 
> Colm.
> 
> On Wed, Nov 15, 2017 at 1:31 PM, Gerard Gagliano <gg@apache.org <mailto:gg@apache.org>>
wrote:
> Colm,
> 
> I don’t know if this is something you still want since the comment was deleted.
> 
> The last commit I see in my IDE is:
> 
> commit 1e6d36497a9509294f30c60a214f1a13f81957b1
> Author: plusplusjiajia <jiajia.li@intel.com <mailto:jiajia.li@intel.com>>
2017-11-14 00:23:40
> Committer: plusplusjiajia <jiajia.li@intel.com <mailto:jiajia.li@intel.com>>
2017-11-14 00:23:40
> Parent: c64cdefc963cb814d1c7b9d64a2f8e0d6cc7d130 (DIRKRB-668 Enable KDC backend connect
to the HA Zookeeper Cluster. Contributed by cclive1601.)
> Branches: trunk, origin/trunk
> 
> DIRKRB-670 Add checksum verification in TgsRequest.
> 
> > On Nov 15, 2017, at 4:26 AM, Colm O hEigeartaigh (JIRA) <jira@apache.org <mailto:jira@apache.org>>
wrote:
> >
> >
> >    [ https://issues.apache.org/jira/browse/DIRKRB-669?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16253312#comment-16253312
<https://issues.apache.org/jira/browse/DIRKRB-669?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16253312#comment-16253312>
]
> >
> > Colm O hEigeartaigh commented on DIRKRB-669:
> > --------------------------------------------
> >
> > The patch still doesn't apply for me. What is the latest commit you see when you
do "git log"?
> >
> >> Authorization data needed by backend code create a circular project reference
> >> -----------------------------------------------------------------------------
> >>
> >>                Key: DIRKRB-669
> >>                URL: https://issues.apache.org/jira/browse/DIRKRB-669 <https://issues.apache.org/jira/browse/DIRKRB-669>
> >>            Project: Directory Kerberos
> >>         Issue Type: Improvement
> >>           Reporter: Gerard Gagliano
> >>           Assignee: Gerard Gagliano
> >>        Attachments: KrbClient.patch
> >>
> >>
> >> Making changes necessitated by the introduction of the KdcClientRequest class
and the associated calling parameter changes has presented a circular reference in kerb-core
and krb-identity.
> >> Many data items needed by the authorization data backend code are not included
in the KdcClientRequest class as defined in the 1.1.0-SNAPSHOT.  Modification of this class
to include the necessary data items includes a reference to the KrbIdentity class.
> >> This creates a circular dependency between the kerb-core project and the kerb-identity
project.  The circular dependency can be resolved by moving KrbIdentity from kerb-identity
to kerb-common.  At the same time, KdcClientRequest can be moved to the same location because
its current location (….kerb.type.kdc) includes only ASN1 classes.
> >> Moving the classes as follows resolves the circular dependency:
> >>   KdcClientRequest from kerb-core, and
> >>   KrbIdentity from kerb-identity
> >>   To kerb-common — package org.apache.kerby.kerberos.kerb.request
> >
> >
> >
> > --
> > This message was sent by Atlassian JIRA
> > (v6.4.14#64029)
> 
> 
> 
> 
> -- 
> Colm O hEigeartaigh
> 
> Talend Community Coder
> http://coders.talend.com <http://coders.talend.com/>


Mime
View raw message