Mailing-List: contact dev-help@directory.apache.org; run by ezmlm
Precedence: bulk
Reply-To: "Apache Directory Developers List" <dev@directory.apache.org>
Date: Fri, 25 Aug 2017 07:30:00 +0000 (UTC)
From: "Emmanuel Lecharny (JIRA)" <jira@apache.org>
To: dev@directory.apache.org
Message-ID: <JIRA.13097402.1503603001000.119024.1503646200327@Atlassian.JIRA>
In-Reply-To: <JIRA.13097402.1503603001000@Atlassian.JIRA>
References: <JIRA.13097402.1503603001000@Atlassian.JIRA> <JIRA.13097402.1503603001956@jira-lw-us.apache.org>
Subject: [jira] [Commented] (DIRSERVER-2207) DefaultSearchEngine does not
 consider sizelimit
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
archived-at: Fri, 25 Aug 2017 07:30:04 -0000


    [ https://issues.apache.org/jira/browse/DIRSERVER-2207?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16141316#comment-16141316 ] 

Emmanuel Lecharny commented on DIRSERVER-2207:
----------------------------------------------

Seems like you had fun with JIRA formatting :-) You can check the presentation by clicking on the little icon on bottom left of this editor, without saving and editing your text again. (it the blue icon with white bars in it, just on the left of the question mark)

That being said, as you mentioned, {{sizeLimit}} is not used by the search engine, but only in the search request handler. Modifying the value in an interceptor should not be problematic, assuming this is the interceptor purpose.

> DefaultSearchEngine does not consider sizelimit
> -----------------------------------------------
>
>                 Key: DIRSERVER-2207
>                 URL: https://issues.apache.org/jira/browse/DIRSERVER-2207
>             Project: Directory ApacheDS
>          Issue Type: Bug
>          Components: core
>    Affects Versions: 2.0.0-M24
>         Environment: independent
>            Reporter: Sebastian Roland
>            Priority: Minor
>             Fix For: 2.0.0
>
>   Original Estimate: 48h
>  Remaining Estimate: 48h
>
> The DefaultSearchEngine is not considering the sizelimit set within the SearchOperationContext as specified in the SearchEngine interface. As it is the only SearchEngine implementation for Partitions so far all Partitions are affected.
> This is problematic in the sense that custom interceptors that would like to restrict the sizelimit based upon certain conditions cannot easily do so by setting the sizelimit on the SearchOperationContext.
> Currently only the sizelimit set by the client / server is considered. doSimpleSearch() within the SearchRequestHandler triggers the interceptor processing ending with the call against the partition which is using the DefaultSearchEngine to obtain the result set (ignoring the sizelimit). When the result is returned back to the call within doSimpleSearch() the result set is stripped to the sizelimit set by the client / server (whichever is less).
> To fix the issue the DefaultSearchEngine should consider the sizelimit set within the SearchOperationContext. Stripping the result set is then obsolete.


--
This message was sent by Atlassian JIRA
(v6.4.14#64029)