Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 774D7200CFE for ; Fri, 25 Aug 2017 07:29:04 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 75C1816C232; Fri, 25 Aug 2017 05:29:04 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id BD44116C230 for ; Fri, 25 Aug 2017 07:29:03 +0200 (CEST) Received: (qmail 52590 invoked by uid 500); 25 Aug 2017 05:29:02 -0000 Mailing-List: contact dev-help@directory.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: "Apache Directory Developers List" Delivered-To: mailing list dev@directory.apache.org Received: (qmail 52573 invoked by uid 99); 25 Aug 2017 05:29:02 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 25 Aug 2017 05:29:02 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id 014E7C10DA for ; Fri, 25 Aug 2017 05:29:02 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -99.202 X-Spam-Level: X-Spam-Status: No, score=-99.202 tagged_above=-999 required=6.31 tests=[KAM_ASCII_DIVIDERS=0.8, RP_MATCHES_RCVD=-0.001, SPF_PASS=-0.001, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id Vx73rg6HRwAv for ; Fri, 25 Aug 2017 05:29:01 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id 1E5AF5F47D for ; Fri, 25 Aug 2017 05:29:01 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 749C5E00A3 for ; Fri, 25 Aug 2017 05:29:00 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 20FC42537E for ; Fri, 25 Aug 2017 05:29:00 +0000 (UTC) Date: Fri, 25 Aug 2017 05:29:00 +0000 (UTC) From: "Sebastian Roland (JIRA)" To: dev@directory.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Comment Edited] (DIRSERVER-2207) DefaultSearchEngine does not consider sizelimit MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 archived-at: Fri, 25 Aug 2017 05:29:04 -0000 [ https://issues.apache.org/jira/browse/DIRSERVER-2207?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16141213#comment-16141213 ] Sebastian Roland edited comment on DIRSERVER-2207 at 8/25/17 5:28 AM: ---------------------------------------------------------------------- What kind of effect does changing the sizelimit using {noformat} searchContext.setSizeLimit( ); {noformat} has? was (Author: seroland86): What kind of effect does changing the sizelimit using {code:java} searchContext.setSizeLimit( ); {code} has? > DefaultSearchEngine does not consider sizelimit > ----------------------------------------------- > > Key: DIRSERVER-2207 > URL: https://issues.apache.org/jira/browse/DIRSERVER-2207 > Project: Directory ApacheDS > Issue Type: Bug > Components: core > Affects Versions: 2.0.0-M24 > Environment: independent > Reporter: Sebastian Roland > Priority: Minor > Fix For: 2.0.0 > > Original Estimate: 48h > Remaining Estimate: 48h > > The DefaultSearchEngine is not considering the sizelimit set within the SearchOperationContext as specified in the SearchEngine interface. As it is the only SearchEngine implementation for Partitions so far all Partitions are affected. > This is problematic in the sense that custom interceptors that would like to restrict the sizelimit based upon certain conditions cannot easily do so by setting the sizelimit on the SearchOperationContext. > Currently only the sizelimit set by the client / server is considered. doSimpleSearch() within the SearchRequestHandler triggers the interceptor processing ending with the call against the partition which is using the DefaultSearchEngine to obtain the result set (ignoring the sizelimit). When the result is returned back to the call within doSimpleSearch() the result set is stripped to the sizelimit set by the client / server (whichever is less). > To fix the issue the DefaultSearchEngine should consider the sizelimit set within the SearchOperationContext. Stripping the result set is then obsolete. -- This message was sent by Atlassian JIRA (v6.4.14#64029)