directory-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Emmanuel Lecharny (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (DIRSERVER-2207) DefaultSearchEngine does not consider sizelimit
Date Fri, 25 Aug 2017 07:30:00 GMT

    [ https://issues.apache.org/jira/browse/DIRSERVER-2207?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16141316#comment-16141316
] 

Emmanuel Lecharny commented on DIRSERVER-2207:
----------------------------------------------

Seems like you had fun with JIRA formatting :-) You can check the presentation by clicking
on the little icon on bottom left of this editor, without saving and editing your text again.
(it the blue icon with white bars in it, just on the left of the question mark)

That being said, as you mentioned, {{sizeLimit}} is not used by the search engine, but only
in the search request handler. Modifying the value in an interceptor should not be problematic,
assuming this is the interceptor purpose.

> DefaultSearchEngine does not consider sizelimit
> -----------------------------------------------
>
>                 Key: DIRSERVER-2207
>                 URL: https://issues.apache.org/jira/browse/DIRSERVER-2207
>             Project: Directory ApacheDS
>          Issue Type: Bug
>          Components: core
>    Affects Versions: 2.0.0-M24
>         Environment: independent
>            Reporter: Sebastian Roland
>            Priority: Minor
>             Fix For: 2.0.0
>
>   Original Estimate: 48h
>  Remaining Estimate: 48h
>
> The DefaultSearchEngine is not considering the sizelimit set within the SearchOperationContext
as specified in the SearchEngine interface. As it is the only SearchEngine implementation
for Partitions so far all Partitions are affected.
> This is problematic in the sense that custom interceptors that would like to restrict
the sizelimit based upon certain conditions cannot easily do so by setting the sizelimit on
the SearchOperationContext.
> Currently only the sizelimit set by the client / server is considered. doSimpleSearch()
within the SearchRequestHandler triggers the interceptor processing ending with the call against
the partition which is using the DefaultSearchEngine to obtain the result set (ignoring the
sizelimit). When the result is returned back to the call within doSimpleSearch() the result
set is stripped to the sizelimit set by the client / server (whichever is less).
> To fix the issue the DefaultSearchEngine should consider the sizelimit set within the
SearchOperationContext. Stripping the result set is then obsolete.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message