directory-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Colm O hEigeartaigh (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (DIRKRB-626) Some improvement work for exception handling
Date Wed, 03 May 2017 11:56:04 GMT

    [ https://issues.apache.org/jira/browse/DIRKRB-626?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15994714#comment-15994714
] 

Colm O hEigeartaigh commented on DIRKRB-626:
--------------------------------------------

Thanks - just one other fix I'd like to see - in kerby-tool/client-tool/src/main/java/org/apache/kerby/kerberos/tool/klist/KlistTool.java
you don't preserve the exception stack trace in the error log.

> Some improvement work for exception handling
> --------------------------------------------
>
>                 Key: DIRKRB-626
>                 URL: https://issues.apache.org/jira/browse/DIRKRB-626
>             Project: Directory Kerberos
>          Issue Type: Bug
>    Affects Versions: 1.0.0-GA
>            Reporter: Lin Zeng
>            Assignee: Lin Zeng
>         Attachments: DIRKRB-626-01.patch, DIRKRB-626-02.patch
>
>
> This is from [~coheigea]'s comment:
> {quote}
> One improvement I'd like to see before the 1.0 GA release is to improve the exception
handling. There are many examples of catch statements that just have a printStackTrace() leading
to NPEs down the line. Apart from that, +1 from me on the release:
> find . -name "*.java" -path "*/main/*" | xargs grep "printStackTrace()" | wc -l
> 30
> {quote} 



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Mime
View raw message