directory-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Emmanuel Lécharny <>
Subject Re: SyntaxCheckers status
Date Mon, 17 Apr 2017 11:17:47 GMT

Le 02/04/2017 à 14:49, Stefan Seelmann a écrit :
> On 03/26/2017 01:40 PM, Emmanuel Lécharny wrote:
>> I'm almost done with the refactoring of SyntaxCheckers, having added a
>> Builder inner class to all of them. I just have to deal with the
>> TelephoneNumber SC which is slightly more complex, but it will be done
>> by tonite.
> Thanks Emmanuel,
> in ApacheDS there were some test failures.
> One was a NPE in TelephoneNumberSyntaxChecker, when that was loaded via
> DefaultSchemaManager the regexp/pattern fields were null. Fixed here:
> Other tests load the syntax checker via bytecode from schema. This
> doesnt' work anymore because now the class contains the inner Builder
> class, so on class loading two classes need to be loaded. Either we need
> two bytecode attributes values or concatentate them and make the
> SchemaEntityFactory handle that. In the meantime I disabled the tests:
> Kind Regards,
> Stefan

I think I have fixed all of the errors, and committed the fix.

Time to switch back to Mavibot :-)

Emmanuel Lecharny

View raw message