Mailing-List: contact dev-help@directory.apache.org; run by ezmlm
Precedence: bulk
Reply-To: "Apache Directory Developers List" <dev@directory.apache.org>
Date: Mon, 6 Mar 2017 09:08:32 +0000 (UTC)
From: "Thilo-Alexander Ginkel (JIRA)" <jira@apache.org>
To: dev@directory.apache.org
Message-ID: <JIRA.13046784.1488234547000.4695.1488791312886@Atlassian.JIRA>
In-Reply-To: <JIRA.13046784.1488234547000@Atlassian.JIRA>
References: <JIRA.13046784.1488234547000@Atlassian.JIRA> <JIRA.13046784.1488234547267@jira-lw-us.apache.org>
Subject: [jira] [Commented] (DIRSERVER-2180) BCrypt password hashing support
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
archived-at: Mon, 06 Mar 2017 09:08:37 -0000


    [ https://issues.apache.org/jira/browse/DIRSERVER-2180?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15896934#comment-15896934 ] 

Thilo-Alexander Ginkel commented on DIRSERVER-2180:
---------------------------------------------------

Hi Emmanuel,

without adding the CheckStyle exception the build failed with > 1000 checkstyle errors in that class. I think it makes much more sense to use the BCrypt implementation as is instead of adjusting it to the project's code formatting guidelines as integrating possible upstream changes becomes a nightmare otherwise.

If I understand correctly the 2a, 2x, 2y version scheme only applies to the OpenBSD BCrypt implementation and is used to version implementation glitches for hashes generated with that very implementation. Any other library I have spotted so far will happily generate 2a hashes in 2017 even though (or because) it probably has never been affected by those glitches / defects. IMHO it is fine to support just 2a as long as one does not need to be bug-compatible with OpenBSD.

> BCrypt password hashing support
> -------------------------------
>
>                 Key: DIRSERVER-2180
>                 URL: https://issues.apache.org/jira/browse/DIRSERVER-2180
>             Project: Directory ApacheDS
>          Issue Type: Improvement
>            Reporter: Thilo-Alexander Ginkel
>            Priority: Minor
>
> At the moment, Apache DS does not support the BCrypt password hashing algorithm.
> As discussed on the dev mailinglist, I'd like to contribute support for this algorithm and am opening this ticket as requested by [~elecharny]. An incomplete prototype (at least OSGi tests are currently broken) is available at [1].
> [1] https://github.com/tgbyte/directory-shared/tree/feature/bcrypt-hash-support


--
This message was sent by Atlassian JIRA
(v6.3.15#6346)