directory-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Emmanuel Lecharny (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (DIRKRB-619) KdcConnection suppresses Exception
Date Thu, 23 Feb 2017 11:07:44 GMT

    [ https://issues.apache.org/jira/browse/DIRKRB-619?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15880262#comment-15880262
] 

Emmanuel Lecharny commented on DIRKRB-619:
------------------------------------------

Something like :

{noformat}
...
            // We didn't received anything : this is an error
            LOG.error( "Authentication failed : {0}", e.getMessage() );
            throw new KerberosException( ErrorType.KRB_ERR_GENERIC, e.getMessage() );
...
{noformat}

should be better ?

> KdcConnection suppresses Exception
> ----------------------------------
>
>                 Key: DIRKRB-619
>                 URL: https://issues.apache.org/jira/browse/DIRKRB-619
>             Project: Directory Kerberos
>          Issue Type: Improvement
>            Reporter: Maciej Miklas
>            Priority: Minor
>
> The Method: {{org.apache.directory.kerberos.client.KdcConnection#_getTgt(...)}}
> has following catch block:
> {code:title=KdcConnection.java|borderStyle=solid}
> catch ( Exception e )
> {
>  // We didn't received anything : this is an error
>    LOG.error( "Authentication failed" );
>    throw new KerberosException( ErrorType.KRB_ERR_GENERIC, TIME_OUT_ERROR );
>  }
> {code}
> The real cause of this error is not being logged and you definitely cannot be 100% sure
that it's a timeout. 
> Please log the original exception, this could be done in debug.  



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Mime
View raw message