directory-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Caleb McQuillin (JIRA)" <>
Subject [jira] [Commented] (DIRAPI-286) AdDirSync Control does not support multiple flags
Date Tue, 29 Nov 2016 12:50:58 GMT


Caleb McQuillin commented on DIRAPI-286:

Just took a look - the changes look great to me. 

It feels good to be able to contribute to this API since it's been a lifesaver for me!

> AdDirSync Control does not support multiple flags
> -------------------------------------------------
>                 Key: DIRAPI-286
>                 URL:
>             Project: Directory Client API
>          Issue Type: Bug
>    Affects Versions: 1.0.0-RC2
>            Reporter: Caleb McQuillin
>             Fix For: 1.0.0-RC3
>         Attachments: AdDirSyncPatch.diff
> When creating an initial search request using the DirSync control, I would like to pass
multiple flags. [Microsoft's documentation|]
> {quote}*Flags*
> Contains optional flags for use with the LDAP_SERVER_DIRSYNC_OID control. This can be
zero or a combination of one or more of the values listed in the following list.{quote}
> Unfortunately, [the IETF document|]
that was linked in the ticket for supporting DirSync (DIRAPI-189) doesn't match the actual
implementation, as specified by Microsoft in the link above. The IETF document only specifies
a {{parentsFirst}} flag in the SearchRequest, but there are four potential SearchRequest flags
(all of which can be found in AdDirFlags). AdDirSync specifies methods for getting and setting
both a {{parentsFirst}} field and a {{flag}} field. In reality, there should be a single {{flags}}
field that is a collection of applicable flags. Additionally, it appears the {{flag}} field
is ignored during encoding and decoding - only the {{parentsFirst}} field is considered.
> My recommendation for resolving this issue revolves around Java's EnumSet class which
seems to be commonly used for bitmasks in Java. I've drafted a patch for use in my project
that is utilizing the Directory Client API, I'd be happy to attach that patch here to be used
at least as a base for resolution of this issue.

This message was sent by Atlassian JIRA

View raw message