Return-Path: X-Original-To: apmail-directory-dev-archive@www.apache.org Delivered-To: apmail-directory-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 8FC0119FAC for ; Fri, 8 Apr 2016 01:10:26 +0000 (UTC) Received: (qmail 9515 invoked by uid 500); 8 Apr 2016 01:10:26 -0000 Delivered-To: apmail-directory-dev-archive@directory.apache.org Received: (qmail 9426 invoked by uid 500); 8 Apr 2016 01:10:25 -0000 Mailing-List: contact dev-help@directory.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: "Apache Directory Developers List" Delivered-To: mailing list dev@directory.apache.org Received: (qmail 9157 invoked by uid 99); 8 Apr 2016 01:10:25 -0000 Received: from arcas.apache.org (HELO arcas) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 08 Apr 2016 01:10:25 +0000 Received: from arcas.apache.org (localhost [127.0.0.1]) by arcas (Postfix) with ESMTP id A8FC92C1F62 for ; Fri, 8 Apr 2016 01:10:25 +0000 (UTC) Date: Fri, 8 Apr 2016 01:10:25 +0000 (UTC) From: "Jiajia Li (JIRA)" To: dev@directory.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (DIRKRB-546) Add super class to AdminSetting and KdcSetting MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/DIRKRB-546?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15231453#comment-15231453 ] Jiajia Li commented on DIRKRB-546: ---------------------------------- Thanks for the updating, it looks good to me, +1. > Add super class to AdminSetting and KdcSetting > ---------------------------------------------- > > Key: DIRKRB-546 > URL: https://issues.apache.org/jira/browse/DIRKRB-546 > Project: Directory Kerberos > Issue Type: Improvement > Reporter: YanYan > Assignee: YanYan > Attachments: DIRKRB-546-v1.patch, DIRKRB-546-v2.patch > > > To add a principal to backend from remote kadmin, we need to invoke {{addPrincipal(String principal)}} method in {{LocalKadminImpl}}. In order to create an object of {{LocalKadminImpl}}, we should add a super class to both {{AdminServerSetting}} and {{KdcSetting}}. -- This message was sent by Atlassian JIRA (v6.3.4#6332)