directory-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Kai Zheng (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (DIRKRB-533) Implementing ApRequest and ApResponse
Date Fri, 19 Feb 2016 07:06:18 GMT

    [ https://issues.apache.org/jira/browse/DIRKRB-533?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15153826#comment-15153826
] 

Kai Zheng commented on DIRKRB-533:
----------------------------------

Thanks Jiajia for the nice work! It looks good to me. Some comments:
1. I guess {{ApRequest}} may be used in both client and server sides. For server side, the
basic logic would be to check and authenticate the request. I thought the codes below can
be moved from {{ApResponse}} here:
{code}
+    /*
+     *  Check the ApReq.
+    */
+    private void checkApReq() throws KrbException {
{code}
2. When you do the moving, {{checkApReq}} could be changed to be as: {{public static void
validate(TGT serverTgt}}. This can be called by one GSSAPI module implementation.
3. Better to have some Javadocs for the newly classes as they're important.
4. How about using the package {{org.apache.kerby.kerberos.kerb.request}} for {{ApRequest}}
and {{org.apache.kerby.kerberos.kerb.response}} for {{ApResonse}}? Later we may possibly move
{{AsRequest/Response}}, {{TgsRequest/Response}} to the place as well, as [~smoyer1] proposed
in the mailing list.

> Implementing ApRequest and ApResponse
> -------------------------------------
>
>                 Key: DIRKRB-533
>                 URL: https://issues.apache.org/jira/browse/DIRKRB-533
>             Project: Directory Kerberos
>          Issue Type: New Feature
>    Affects Versions: 1.0.0-RC2
>            Reporter: Jiajia Li
>            Assignee: Jiajia Li
>         Attachments: DIRKRB-533-V1.patch
>
>
> ApRequest is used to create ApReq.
> ApResponse is used by app server to check the ApReq and create ApRep.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message