Return-Path: X-Original-To: apmail-directory-dev-archive@www.apache.org Delivered-To: apmail-directory-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 3684D18E25 for ; Fri, 29 Jan 2016 07:25:43 +0000 (UTC) Received: (qmail 8408 invoked by uid 500); 29 Jan 2016 07:25:39 -0000 Delivered-To: apmail-directory-dev-archive@directory.apache.org Received: (qmail 8349 invoked by uid 500); 29 Jan 2016 07:25:39 -0000 Mailing-List: contact dev-help@directory.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: "Apache Directory Developers List" Delivered-To: mailing list dev@directory.apache.org Received: (qmail 8339 invoked by uid 99); 29 Jan 2016 07:25:39 -0000 Received: from arcas.apache.org (HELO arcas) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 29 Jan 2016 07:25:39 +0000 Received: from arcas.apache.org (localhost [127.0.0.1]) by arcas (Postfix) with ESMTP id C46AF2C1F54 for ; Fri, 29 Jan 2016 07:25:39 +0000 (UTC) Date: Fri, 29 Jan 2016 07:25:39 +0000 (UTC) From: "Jan Sindberg (JIRA)" To: dev@directory.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (FC-143) Let LdapClientTrustStoreManager read trust store from jar MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/FC-143?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15123133#comment-15123133 ] Jan Sindberg commented on FC-143: --------------------------------- I think that I made a last minute change that I shouldn't have done. I forgot about files outside classpath. Also I can't remember why I have to test with the pushback input stream - I think that is a bit theoretic situation like pointing to a web-resource that doesn't exist. We could probably boil it down to {code} private InputStream getInputStream(String _fileName) { InputStream result = null; final File file = new File(_fileName); if (file.exists()) { try { result = new FileInputStream(file); } catch (FileNotFoundException e) { // Don't care } } else { result = this.getClass().getClassLoader().getResourceAsStream(_fileName); } return result; } {/code} > Let LdapClientTrustStoreManager read trust store from jar > --------------------------------------------------------- > > Key: FC-143 > URL: https://issues.apache.org/jira/browse/FC-143 > Project: FORTRESS > Issue Type: Improvement > Affects Versions: 1.0.0-RC41 > Reporter: Jan Sindberg > Priority: Minor > Fix For: 1.0.0-RC41 > > Attachments: [FC-143]_-_Let_LdapClientTrustStoreManager_read_trust_store_from_jar.patch > > > *Use case * > Creating a small utility to initialize configuration (setting system properties) which serves up the right parameters and also contains trust stores. > That way we can quickly set up for test locally at developer machines, as well on test environments and prod. > *Problem* > LdapClientTrustStoreManager expects a fully-qualified name of a Java TrustStore on local file system. > *Proposed solution* > Get an input stream to the trust store. Test if it is a local file. If it is not, then test if an inputstream can be created from resources. > Patch attached. -- This message was sent by Atlassian JIRA (v6.3.4#6332)