Return-Path: X-Original-To: apmail-directory-dev-archive@www.apache.org Delivered-To: apmail-directory-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 4E5B5180BA for ; Sat, 9 Jan 2016 00:12:40 +0000 (UTC) Received: (qmail 70101 invoked by uid 500); 9 Jan 2016 00:12:40 -0000 Delivered-To: apmail-directory-dev-archive@directory.apache.org Received: (qmail 70039 invoked by uid 500); 9 Jan 2016 00:12:40 -0000 Mailing-List: contact dev-help@directory.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: "Apache Directory Developers List" Delivered-To: mailing list dev@directory.apache.org Received: (qmail 70029 invoked by uid 99); 9 Jan 2016 00:12:40 -0000 Received: from arcas.apache.org (HELO arcas) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 09 Jan 2016 00:12:40 +0000 Received: from arcas.apache.org (localhost [127.0.0.1]) by arcas (Postfix) with ESMTP id C06502C14F0 for ; Sat, 9 Jan 2016 00:12:39 +0000 (UTC) Date: Sat, 9 Jan 2016 00:12:39 +0000 (UTC) From: "Shawn McKinney (JIRA)" To: dev@directory.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (FC-135) Rename ambigous getter and setters names on User and UserAdminRole MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/FC-135?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15090248#comment-15090248 ] Shawn McKinney commented on FC-135: ----------------------------------- Pull Request received: GitHub user pike1212 opened a pull request: https://github.com/apache/directory-fortress-core/pull/4 Rename Set Methods to avoid Conflict I renamed the duplicate set methods. My junit tests don't work even before I made the change, so not sure how to propertly test. This is the error I get when running "mvn test -Dtest=FortressJUnitTest" Tests run: 141, Failures: 5, Errors: 0, Skipped: 0, Time elapsed: 228.481 sec <<< FAILURE! - in org.apache.directory.fortress.core.impl.FortressJUnitTest testSearchBinds(org.apache.directory.fortress.core.impl.AuditMgrImplTest) Time elapsed: 0.022 sec <<< FAILURE! junit.framework.AssertionFailedError: org.apache.directory.fortress.core.impl.AuditMgrImplTestsearchBinds failed search for successful authentication user [jtsUser1] at junit.framework.Assert.fail(Assert.java:57) at junit.framework.Assert.assertTrue(Assert.java:22) at junit.framework.TestCase.assertTrue(TestCase.java:192) at org.apache.directory.fortress.core.impl.AuditMgrImplTest.searchBinds(AuditMgrImplTest.java:426) at org.apache.directory.fortress.core.impl.AuditMgrImplTest.testSearchBinds(AuditMgrImplTest.java:399) You can merge this pull request into a Git repository by running: $ git pull https://github.com/PennState/directory-fortress-core-1 master Alternatively you can review and apply these changes as the patch at: https://github.com/apache/directory-fortress-core/pull/4.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #4 ---- commit 1e664a2e49b65c33e323e43beba88c0816601076 Author: clp207 Date: 2016-01-05T17:01:31Z renamed set methods with same name in models commit 417dc4d23858a059306f3a1d5b3f0588e71f74f3 Author: clp207 Date: 2016-01-05T18:12:31Z changed method name to have List isntead of 's' commit eae93c8ff3eb1f2b7e556ff35191a06fa4b30564 Author: clp207 Date: 2016-01-05T18:21:14Z fixed test classes ---- > Rename ambigous getter and setters names on User and UserAdminRole > ------------------------------------------------------------------ > > Key: FC-135 > URL: https://issues.apache.org/jira/browse/FC-135 > Project: FORTRESS > Issue Type: Improvement > Affects Versions: 1.0.0-RC40 > Reporter: Shawn McKinney > Fix For: 1.0.0-RC41 > > > Ticket was a request from Chris Pike: > On Jan 5, 2016, at 10:35 AM, Chris Pike wrote: > There are a couple instances where models have multiple set methods for the same field. > UserAdminRole has... > public void setOsP( String osP ) > public void setOsP( Set osPs ) > public void setOsU( Set osUs ) > public void setOsU( String osU ) > User has... > public void setRole( String roleName ) > public void setRole( UserRole role ) > public void setAdminRole( UserAdminRole role ) > public void setAdminRole( String roleName ) > This is causing some issues down the line with jackson. I have a workaround but wanted to see if there was any possibility of changing one of the method names. -- This message was sent by Atlassian JIRA (v6.3.4#6332)