Mailing-List: contact dev-help@directory.apache.org; run by ezmlm
Precedence: bulk
Reply-To: "Apache Directory Developers List" <dev@directory.apache.org>
Date: Sat, 9 Jan 2016 00:10:40 +0000 (UTC)
From: "Shawn McKinney (JIRA)" <jira@apache.org>
To: dev@directory.apache.org
Message-ID: <JIRA.12928453.1452202070000.63460.1452298240042@Atlassian.JIRA>
In-Reply-To: <JIRA.12928453.1452202070000@Atlassian.JIRA>
References: <JIRA.12928453.1452202070000@Atlassian.JIRA>
 <JIRA.12928453.1452202070110@arcas>
Subject: [jira] [Commented] (FC-134) Don't initialize extended ldap controls
 with system properties
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/FC-134?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15090243#comment-15090243 ] 

Shawn McKinney commented on FC-134:
-----------------------------------

Pull Request was received:

GitHub user pike1212 opened a pull request:

   https://github.com/apache/directory-fortress-core/pull/4

   Rename Set Methods to avoid Conflict

   I renamed the duplicate set methods. My junit tests don't work even before I made the change, so not sure how to propertly test. This is the error I get when running "mvn test -Dtest=FortressJUnitTest"


   Tests run: 141, Failures: 5, Errors: 0, Skipped: 0, Time elapsed: 228.481 sec <<< FAILURE! - in org.apache.directory.fortress.core.impl.FortressJUnitTest
   testSearchBinds(org.apache.directory.fortress.core.impl.AuditMgrImplTest)  Time elapsed: 0.022 sec  <<< FAILURE!
   junit.framework.AssertionFailedError: org.apache.directory.fortress.core.impl.AuditMgrImplTestsearchBinds failed search for successful authentication user [jtsUser1]
   	at junit.framework.Assert.fail(Assert.java:57)
   	at junit.framework.Assert.assertTrue(Assert.java:22)
   	at junit.framework.TestCase.assertTrue(TestCase.java:192)
   	at org.apache.directory.fortress.core.impl.AuditMgrImplTest.searchBinds(AuditMgrImplTest.java:426)
   	at org.apache.directory.fortress.core.impl.AuditMgrImplTest.testSearchBinds(AuditMgrImplTest.java:399)


You can merge this pull request into a Git repository by running:

   $ git pull https://github.com/PennState/directory-fortress-core-1 master

Alternatively you can review and apply these changes as the patch at:

   https://github.com/apache/directory-fortress-core/pull/4.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

   This closes #4

----
commit 1e664a2e49b65c33e323e43beba88c0816601076
Author: clp207 <clp207@psu.edu>
Date:   2016-01-05T17:01:31Z

   renamed set methods with same name in models

commit 417dc4d23858a059306f3a1d5b3f0588e71f74f3
Author: clp207 <clp207@psu.edu>
Date:   2016-01-05T18:12:31Z

   changed method name to have List isntead of 's'

commit eae93c8ff3eb1f2b7e556ff35191a06fa4b30564
Author: clp207 <clp207@psu.edu>
Date:   2016-01-05T18:21:14Z

   fixed test classes

----

> Don't initialize extended ldap controls with system properties
> --------------------------------------------------------------
>
>                 Key: FC-134
>                 URL: https://issues.apache.org/jira/browse/FC-134
>             Project: FORTRESS
>          Issue Type: Bug
>    Affects Versions: 1.0.0-RC40
>            Reporter: Shawn McKinney
>             Fix For: 1.0.0-RC41
>
>
> Problem arose in an environment with another app that uses apache ldap api.  The problem is fortress core initializes its extended ldap controls using system properties like this:
>  System.setProperty( StandaloneLdapApiService.EXTENDED_OPERATIONS_LIST,             "org.openldap.accelerator.impl.createSession.RbacCreateSessionFactory,"
>                     + "org.openldap.accelerator.impl.checkAccess.RbacCheckAccessFactory,"
>                     + "org.openldap.accelerator.impl.addRole.RbacAddRoleFactory,"
>                     + "org.openldap.accelerator.impl.dropRole.RbacDropRoleFactory,"
>                     + "org.openldap.accelerator.impl.deleteSession.RbacDeleteSessionFactory,"
>                     + "org.openldap.accelerator.impl.sessionRoles.RbacSessionRolesFactory"
>                 );
> which classes with another program in same tomcat instance.  When the 2nd program fires up ldap api, it tries to load the same extended ldap classes and gets a class not found exception.


--
This message was sent by Atlassian JIRA
(v6.3.4#6332)