Return-Path: X-Original-To: apmail-directory-dev-archive@www.apache.org Delivered-To: apmail-directory-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 3133A18D84 for ; Thu, 7 Jan 2016 13:18:40 +0000 (UTC) Received: (qmail 61718 invoked by uid 500); 7 Jan 2016 13:18:40 -0000 Delivered-To: apmail-directory-dev-archive@directory.apache.org Received: (qmail 61638 invoked by uid 500); 7 Jan 2016 13:18:40 -0000 Mailing-List: contact dev-help@directory.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: "Apache Directory Developers List" Delivered-To: mailing list dev@directory.apache.org Received: (qmail 61606 invoked by uid 99); 7 Jan 2016 13:18:39 -0000 Received: from arcas.apache.org (HELO arcas) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 07 Jan 2016 13:18:39 +0000 Received: from arcas.apache.org (localhost [127.0.0.1]) by arcas (Postfix) with ESMTP id D827B2C1F56 for ; Thu, 7 Jan 2016 13:18:39 +0000 (UTC) Date: Thu, 7 Jan 2016 13:18:39 +0000 (UTC) From: "Emmanuel Lecharny (JIRA)" To: dev@directory.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (DIRKRB-523) Avoid outputting data to System.out in Asn1 + Asn1Dumper MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/DIRKRB-523?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15087342#comment-15087342 ] Emmanuel Lecharny commented on DIRKRB-523: ------------------------------------------ What we usually see in many project is a {{dump()}} method that return a {{String}}, up to the callers to write this {{String}} on {{System.out}} o whatever they prefer. IMO, dumping on {{System.out}} is a bit rigid. > Avoid outputting data to System.out in Asn1 + Asn1Dumper > -------------------------------------------------------- > > Key: DIRKRB-523 > URL: https://issues.apache.org/jira/browse/DIRKRB-523 > Project: Directory Kerberos > Issue Type: Bug > Reporter: Colm O hEigeartaigh > > I notice a lot of text output in the Kerby tests along the lines of: > Dumping data: > >60818561101A044A6F686E1A01501A05536D697468A00A1A084469726563746F72420133A10A43083139373130393137A212 > 61101A044D6172791A01541A05536D697468A342311F61111A0552616C70681A01541A05536D697468A00A43083139353731 > 313131311F61111A05537573616E1A01421A054A6F6E6573A00A43083139353930373137 > application [0] [tag=0x60, off=0, len=3+133] > etc. > > Both the Asn1 + Asn1Dumper classes are outputting data using System.out.println(). I don't think this is a good idea, that classes in > src/main/java are outputting data to system.out. Is there a reason for > this? Surely if anything, the Asn1Dumper could output to a log instead. -- This message was sent by Atlassian JIRA (v6.3.4#6332)