directory-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Shawn McKinney (JIRA)" <j...@apache.org>
Subject [jira] [Resolved] (FC-136) Permission entity equals doesn't check for object id.
Date Sat, 09 Jan 2016 01:51:39 GMT

     [ https://issues.apache.org/jira/browse/FC-136?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Shawn McKinney resolved FC-136.
-------------------------------
    Resolution: Fixed

Added objId to the equals:

    /**
     * Matches the objName, opName and objId from two Permission entities.
     *
     * @param o contains a Permission entity.
     * @return boolean indicating both Permissions contain matching objName and opName attributes.
     */
    @Override
    public boolean equals(Object o)
    {
        if ( this == o )
        {
            return true;
        }
        if ( o == null || getClass() != o.getClass() )
        {
            return false;
        }

        Permission that = ( Permission ) o;

        if ( StringUtils.isNotEmpty( objId ) ? !objId.equalsIgnoreCase( that.objId ) : StringUtils.isNotEmpty(
that.objId ) )
        {
            return false;
        }
        if ( objName != null ? !objName.equalsIgnoreCase( that.objName ) : that.objName !=
null )
        {
            return false;
        }
        if ( opName != null ? !opName.equalsIgnoreCase( that.opName ) : that.opName != null
)
        {
            return false;
        }

        return true;
    }

> Permission entity equals doesn't check for object id.
> -----------------------------------------------------
>
>                 Key: FC-136
>                 URL: https://issues.apache.org/jira/browse/FC-136
>             Project: FORTRESS
>          Issue Type: Bug
>    Affects Versions: 1.0.0-RC40
>            Reporter: Shawn McKinney
>             Fix For: 1.0.0-RC41
>
>
> Add object id check to equals method.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message