directory-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Kai Zheng (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (DIRKRB-523) Avoid outputting data to System.out in Asn1 + Asn1Dumper
Date Thu, 07 Jan 2016 13:44:39 GMT

    [ https://issues.apache.org/jira/browse/DIRKRB-523?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15087360#comment-15087360
] 

Kai Zheng commented on DIRKRB-523:
----------------------------------

Yes as discussed above we'll have new method(s) like {{dumpAsString}} or the like to return
the dumped content for the callers to proceed. The current methods that dump to console are
mainly for our own's sake, it's so convenient if you want to inspect any bits stream, Asn1
object, then dump it and it's there, in the IDE, or command line. We at least make ourselves
happy because debugging is so hard. :)


> Avoid outputting data to System.out in Asn1 + Asn1Dumper
> --------------------------------------------------------
>
>                 Key: DIRKRB-523
>                 URL: https://issues.apache.org/jira/browse/DIRKRB-523
>             Project: Directory Kerberos
>          Issue Type: Bug
>            Reporter: Colm O hEigeartaigh
>
> I notice a lot of text output in the Kerby tests along the lines of:
> Dumping data:
> >60818561101A044A6F686E1A01501A05536D697468A00A1A084469726563746F72420133A10A43083139373130393137A212
> 61101A044D6172791A01541A05536D697468A342311F61111A0552616C70681A01541A05536D697468A00A43083139353731
> 313131311F61111A05537573616E1A01421A054A6F6E6573A00A43083139353930373137
> application [0] [tag=0x60, off=0, len=3+133]
> etc.
>  
> Both the Asn1 + Asn1Dumper classes are outputting data using System.out.println(). I
don't think this is a good idea, that classes in
> src/main/java are outputting data to system.out. Is there a reason for
> this? Surely if anything, the Asn1Dumper could output to a log instead.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message