directory-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Kai Zheng (JIRA)" <>
Subject [jira] [Commented] (DIRKRB-523) Avoid outputting data to System.out in Asn1 + Asn1Dumper
Date Thu, 07 Jan 2016 11:23:39 GMT


Kai Zheng commented on DIRKRB-523:

I thought the {{dump}} is clear in its meaning that outputs something in the console. It's
very helpful in relevant troubleshooting but I guess some time when it's stable then we can
let them shut up during the building. We just comment out the calling places in the tests.
Let's do this in this issue.

Regarding in the library, the API itself please keep it. It's planned to allow some method
to get the content back so the callers can decide where to output. 

> Avoid outputting data to System.out in Asn1 + Asn1Dumper
> --------------------------------------------------------
>                 Key: DIRKRB-523
>                 URL:
>             Project: Directory Kerberos
>          Issue Type: Bug
>            Reporter: Colm O hEigeartaigh
> I notice a lot of text output in the Kerby tests along the lines of:
> Dumping data:
> >60818561101A044A6F686E1A01501A05536D697468A00A1A084469726563746F72420133A10A43083139373130393137A212
> 61101A044D6172791A01541A05536D697468A342311F61111A0552616C70681A01541A05536D697468A00A43083139353731
> 313131311F61111A05537573616E1A01421A054A6F6E6573A00A43083139353930373137
> application [0] [tag=0x60, off=0, len=3+133]
> etc.
> Both the Asn1 + Asn1Dumper classes are outputting data using System.out.println(). I
don't think this is a good idea, that classes in
> src/main/java are outputting data to system.out. Is there a reason for
> this? Surely if anything, the Asn1Dumper could output to a log instead.

This message was sent by Atlassian JIRA

View raw message