directory-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Emmanuel Lécharny <elecha...@gmail.com>
Subject Re: [API] Added Microsoft control
Date Tue, 20 Oct 2015 19:31:14 GMT
Le 20/10/15 21:24, Radovan Semancik a écrit :
> Hi,
>
> On 10/20/2015 09:08 PM, Emmanuel Lécharny wrote:
>> I just saw that you have added the control you needed. That was fast !
>
> Actually I had most of the code done on Sunday evening and tested it
> on Monday. I've only delayed the commit because of the release ...
> When you need to have AD integration working ASAP you just have to do
> miracles :-)

You know, as soon as the tag is created, you can commit some new code.
Worst case, we revert it. But I understand the rational, and I must say
that if we can avoid a revert, that's better (SVN #WTF !)

>
>> To be clear, we also have those two methods in CascadeImpl control, and
>> I also think this is not necessary. AFAIR, I think those two methods are
>> part of the ControlDecorator interface, we most certainly can remove
>> them.
>
> That was exactly the reason that I've put them in Deleted control. The
> Cascade control is almost exactly the same style as ShowDeleted, so
> I've used that as a starting point. I was curious about these methods,
> but I though that as they are already in Cascade they most likely have
> some purpose. Looks like I was wrong ...
I'll remove them in both controls. 10 years old code start to shows its
age ;-)

Thanks Radovan !

Mime
View raw message