Return-Path: X-Original-To: apmail-directory-dev-archive@www.apache.org Delivered-To: apmail-directory-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id E623F18CA0 for ; Fri, 17 Jul 2015 03:12:04 +0000 (UTC) Received: (qmail 37032 invoked by uid 500); 17 Jul 2015 03:12:04 -0000 Delivered-To: apmail-directory-dev-archive@directory.apache.org Received: (qmail 36970 invoked by uid 500); 17 Jul 2015 03:12:04 -0000 Mailing-List: contact dev-help@directory.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: "Apache Directory Developers List" Delivered-To: mailing list dev@directory.apache.org Received: (qmail 36956 invoked by uid 99); 17 Jul 2015 03:12:04 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 17 Jul 2015 03:12:04 +0000 Date: Fri, 17 Jul 2015 03:12:04 +0000 (UTC) From: "Xu Yaning (JIRA)" To: dev@directory.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (DIRKRB-368) Fix findbugs Problems for kerby-tool module MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/DIRKRB-368?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14630703#comment-14630703 ] Xu Yaning commented on DIRKRB-368: ---------------------------------- Thanks for Lin's review, your suggestion is good to me, I'll handle it. > Fix findbugs Problems for kerby-tool module > ------------------------------------------- > > Key: DIRKRB-368 > URL: https://issues.apache.org/jira/browse/DIRKRB-368 > Project: Directory Kerberos > Issue Type: Sub-task > Reporter: Xu Yaning > Assignee: Xu Yaning > Attachments: DIRKRB-368-v1.patch, DIRKRB-368-v2.patch, DIRKRB-368-v3.patch > > > Findbugs maven plugin reports the following problems: > # *org.apache.kerby.kerberos.tool.kinit.KinitOption.setDescription(String)* unconditionally sets the field description; > # *org.apache.kerby.kerberos.tool.kinit.KinitOption.setName(String)* unconditionally sets the field name; > # *org.apache.kerby.kerberos.tool.kinit.KinitOption.setType(KOptionType)* unconditionally sets the field type; > # *org.apache.kerby.kerberos.tool.kinit.KinitOption.setValue(Object)* unconditionally sets the field value; > # *org.apache.kerby.kerberos.tool.klist.KlistOption.setDescription(String)* unconditionally sets the field description; > # *org.apache.kerby.kerberos.tool.klist.KlistOption.setName(String)* unconditionally sets the field name; > # *org.apache.kerby.kerberos.tool.klist.KlistOption.setType(KOptionType)* unconditionally sets the field type; > # *org.apache.kerby.kerberos.tool.klist.KlistOption.setValue(Object)* unconditionally sets the field value. > # Dead store to error in *org.apache.kerby.kerberos.tool.kinit.KinitTool.main(String[])*; > # Found reliance on default encoding in *org.apache.kerby.kerberos.tool.kinit.KinitTool.getPassword(String)*: new java.util.Scanner(InputStream); > # *org.apache.kerby.kerberos.tool.klist.KlistTool.printCredentialCacheInfo(KOptions)* may fail to clean up java.io.InputStream; > # Found reliance on default encoding in *org.apache.kerby.kerberos.tool.token.TokenCache.readToken(String)*: new java.io.FileReader(File); > # Found reliance on default encoding in *org.apache.kerby.kerberos.tool.token.TokenCache.writeToken(String)*: new java.io.FileWriter(File); > # *org.apache.kerby.kerberos.tool.token.TokenCache.writeToken(String)* may fail to clean up java.io.Writer on checked exception; > # Exceptional return value of java.io.File.delete() ignored in *org.apache.kerby.kerberos.tool.token.TokenCache.writeToken(String)*; > # Exceptional return value of java.io.File.setWritable(boolean, boolean) ignored in *org.apache.kerby.kerberos.tool.token.TokenCache.writeToken(String)*; > # Found reliance on default encoding in *org.apache.kerby.kerberos.tool.kadmin.KadminTool.main(String[])*: new java.util.Scanner(InputStream); > # There is an apparent infinite loop in *org.apache.kerby.kerberos.tool.kadmin.KadminTool.main(String[])*; > # Found reliance on default encoding in *org.apache.kerby.kerberos.tool.kadmin.ToolUtil.getReplay(String)*: new java.util.Scanner(InputStream); > # Found reliance on default encoding in *org.apache.kerby.kerberos.tool.kadmin.command.AddPrincipalCommand.getPassword(String)*: new java.util.Scanner(InputStream); > # Found reliance on default encoding in *org.apache.kerby.kerberos.tool.kadmin.command.ChangePasswordCommand.getPassword(String)*: new java.util.Scanner(InputStream); > # Found reliance on default encoding in *org.apache.kerby.kerberos.tool.kadmin.command.DeletePrincipalCommand.execute(String)*: new java.util.Scanner(InputStream); > # Possible null pointer dereference of principalNames in *org.apache.kerby.kerberos.tool.kadmin.command.ListPrincipalCommand.execute(String)*; > # Dead store to error in *org.apache.kerby.kerberos.tool.kadmin.command.ModifyPrincipalCommand.parseOptions(String[])*; > # Read of unwritten field kOptions in *org.apache.kerby.kerberos.tool.kadmin.command.ModifyPrincipalCommand.parseOptions(String[])*; > # Unwritten field: *org.apache.kerby.kerberos.tool.kadmin.command.ModifyPrincipalCommand.kOptions*; > Problems 1 to 8 are required to be fixed in DIRKRB-367, the others are to be fixed here. -- This message was sent by Atlassian JIRA (v6.3.4#6332)