Return-Path: X-Original-To: apmail-directory-dev-archive@www.apache.org Delivered-To: apmail-directory-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 2B0F118F78 for ; Tue, 14 Jul 2015 07:25:05 +0000 (UTC) Received: (qmail 41960 invoked by uid 500); 14 Jul 2015 07:25:05 -0000 Delivered-To: apmail-directory-dev-archive@directory.apache.org Received: (qmail 41908 invoked by uid 500); 14 Jul 2015 07:25:05 -0000 Mailing-List: contact dev-help@directory.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: "Apache Directory Developers List" Delivered-To: mailing list dev@directory.apache.org Received: (qmail 41898 invoked by uid 99); 14 Jul 2015 07:25:05 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 14 Jul 2015 07:25:05 +0000 Date: Tue, 14 Jul 2015 07:25:04 +0000 (UTC) From: "Xu Yaning (JIRA)" To: dev@directory.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Created] (DIRKRB-368) Fix findbugs Problems for kerby-tool module MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 Xu Yaning created DIRKRB-368: -------------------------------- Summary: Fix findbugs Problems for kerby-tool module Key: DIRKRB-368 URL: https://issues.apache.org/jira/browse/DIRKRB-368 Project: Directory Kerberos Issue Type: Sub-task Reporter: Xu Yaning Findbugs maven plugin reports the following problems: # *org.apache.kerby.kerberos.tool.kinit.KinitOption.setDescription(String)* unconditionally sets the field description; # *org.apache.kerby.kerberos.tool.kinit.KinitOption.setName(String)* unconditionally sets the field name; # *org.apache.kerby.kerberos.tool.kinit.KinitOption.setType(KOptionType)* unconditionally sets the field type; # *org.apache.kerby.kerberos.tool.kinit.KinitOption.setValue(Object)* unconditionally sets the field value; # *org.apache.kerby.kerberos.tool.klist.KlistOption.setDescription(String)* unconditionally sets the field description; # *org.apache.kerby.kerberos.tool.klist.KlistOption.setName(String)* unconditionally sets the field name; # *org.apache.kerby.kerberos.tool.klist.KlistOption.setType(KOptionType)* unconditionally sets the field type; # *org.apache.kerby.kerberos.tool.klist.KlistOption.setValue(Object)* unconditionally sets the field value. # Dead store to error in *org.apache.kerby.kerberos.tool.kinit.KinitTool.main(String[])*; # Found reliance on default encoding in *org.apache.kerby.kerberos.tool.kinit.KinitTool.getPassword(String)*: new java.util.Scanner(InputStream); # *org.apache.kerby.kerberos.tool.klist.KlistTool.printCredentialCacheInfo(KOptions)* may fail to clean up java.io.InputStream; # Found reliance on default encoding in *org.apache.kerby.kerberos.tool.token.TokenCache.readToken(String)*: new java.io.FileReader(File); # Found reliance on default encoding in *org.apache.kerby.kerberos.tool.token.TokenCache.writeToken(String)*: new java.io.FileWriter(File); # *org.apache.kerby.kerberos.tool.token.TokenCache.writeToken(String)* may fail to clean up java.io.Writer on checked exception; # Exceptional return value of java.io.File.delete() ignored in *org.apache.kerby.kerberos.tool.token.TokenCache.writeToken(String)*; # Exceptional return value of java.io.File.setWritable(boolean, boolean) ignored in *org.apache.kerby.kerberos.tool.token.TokenCache.writeToken(String)*; Problems 1 to 8 are required to be fixed in DIRKRB-367, the others are to be fixed here. -- This message was sent by Atlassian JIRA (v6.3.4#6332)