Return-Path: X-Original-To: apmail-directory-dev-archive@www.apache.org Delivered-To: apmail-directory-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id EAA9818B69 for ; Wed, 15 Jul 2015 07:49:04 +0000 (UTC) Received: (qmail 25444 invoked by uid 500); 15 Jul 2015 07:49:04 -0000 Delivered-To: apmail-directory-dev-archive@directory.apache.org Received: (qmail 25385 invoked by uid 500); 15 Jul 2015 07:49:04 -0000 Mailing-List: contact dev-help@directory.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: "Apache Directory Developers List" Delivered-To: mailing list dev@directory.apache.org Received: (qmail 25373 invoked by uid 99); 15 Jul 2015 07:49:04 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 15 Jul 2015 07:49:04 +0000 Date: Wed, 15 Jul 2015 07:49:04 +0000 (UTC) From: "Jiajia Li (JIRA)" To: dev@directory.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (DIRKRB-357) Fix findbugs Problems for kerby-backend MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/DIRKRB-357?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14627680#comment-14627680 ] Jiajia Li commented on DIRKRB-357: ---------------------------------- V3 is fine, thanks for Yaning's contribution. commit 57e0f302be012fe22dbb2a5a4e3291794c2ea6f0 Author: plusplusjiajia Date: Wed Jul 15 15:52:59 2015 +0800 DIRKRB-357 Fix findbugs Problems for kerby-backend. Contributed by Yaning. > Fix findbugs Problems for kerby-backend > --------------------------------------- > > Key: DIRKRB-357 > URL: https://issues.apache.org/jira/browse/DIRKRB-357 > Project: Directory Kerberos > Issue Type: Sub-task > Reporter: Xu Yaning > Attachments: DIRKRB-357-v1.patch, DIRKRB-357-v2.patch, DIRKRB-357-v3.patch > > > Fix findbugs Problems for kerby-backend. The findbugs maven plugin reports the following problems: > # Boxing/unboxing to parse a primitive *org.apache.kerby.kerberos.kdc.identitybackend.typeAdapter.KerberosTimeAdapter.deserialize(JsonElement, Type, JsonDeserializationContext)*; > # Should *org.apache.kerby.kerberos.kdc.identitybackend.LdapIdentityBackend$KeysInfo* be a _static_ inner class?; > # Exceptional return value of java.io.File.mkdirs() ignored in new *org.apache.kerby.MavibotBackend(File)*; > # Exceptional return value of java.io.File.mkdirs() ignored in *org.apache.kerby.kerberos.kdc.identitybackend.ZookeeperIdentityBackend.init()*. -- This message was sent by Atlassian JIRA (v6.3.4#6332)