Return-Path: X-Original-To: apmail-directory-dev-archive@www.apache.org Delivered-To: apmail-directory-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 1567F1844E for ; Mon, 13 Jul 2015 03:38:10 +0000 (UTC) Received: (qmail 4800 invoked by uid 500); 13 Jul 2015 03:38:09 -0000 Delivered-To: apmail-directory-dev-archive@directory.apache.org Received: (qmail 4754 invoked by uid 500); 13 Jul 2015 03:38:09 -0000 Mailing-List: contact dev-help@directory.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: "Apache Directory Developers List" Delivered-To: mailing list dev@directory.apache.org Received: (qmail 4744 invoked by uid 99); 13 Jul 2015 03:38:09 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 13 Jul 2015 03:38:09 +0000 Date: Mon, 13 Jul 2015 03:38:09 +0000 (UTC) From: "Xu Yaning (JIRA)" To: dev@directory.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Updated] (DIRKRB-353) Fix findbugs Problem for lib module MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/DIRKRB-353?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Xu Yaning updated DIRKRB-353: ----------------------------- Description: For lib module, findbugs reports 10 problems to fix: # Found reliance on default encoding in *org.apache.kerby.config.IniConfigLoader.loadConfig(ConfigImpl, Resource)*: new java.io.InputStreamReader(InputStream); # *org.apache.kerby.config.IniConfigLoader.loadConfig(ConfigImpl, Resource)* may fail to close stream; # *org.apache.kerby.config.MapConfigLoader.loadConfig(ConfigImpl, Resource)* makes inefficient use of keySet iterator instead of entrySet iterator; # instanceof will always return true for all non-null values in *org.apache.kerby.config.PropertiesConfigLoader.loadConfig(ConfigImpl, Properties)*, since all String are instances of String; # new *org.apache.kerby.config.Resource(String, File, Resource$Format)* may fail to clean up java.io.InputStream; # Redundant nullcheck of name, which is known to be non-null in *org.apache.kerby.config.XmlConfigLoader.loadConfig(ConfigImpl, Element)*; # Boxing/unboxing to parse a primitive *org.apache.kerby.KOptions.getIntegerOption(KOption)*; # *org.apache.kerby.KOptions.getBooleanOption(KOption)* has Boolean return type and returns explicit null; # Switch statement found in *org.apache.kerby.util.Base64.decode(byte[], int, int)* where default case is missing; # Switch statement found in *org.apache.kerby.util.Base64.encode(byte[], int, int)* where default case is missing. was: For lib module, findbugs reports 6 problems to fix: # Found reliance on default encoding in *org.apache.kerby.config.IniConfigLoader.loadConfig(ConfigImpl, Resource)*: new java.io.InputStreamReader(InputStream); # *org.apache.kerby.config.IniConfigLoader.loadConfig(ConfigImpl, Resource)* may fail to close stream; # *org.apache.kerby.config.MapConfigLoader.loadConfig(ConfigImpl, Resource)* makes inefficient use of keySet iterator instead of entrySet iterator; # instanceof will always return true for all non-null values in *org.apache.kerby.config.PropertiesConfigLoader.loadConfig(ConfigImpl, Properties)*, since all String are instances of String; # new *org.apache.kerby.config.Resource(String, File, Resource$Format)* may fail to clean up java.io.InputStream; # Redundant nullcheck of name, which is known to be non-null in *org.apache.kerby.config.XmlConfigLoader.loadConfig(ConfigImpl, Element)*; # Boxing/unboxing to parse a primitive *org.apache.kerby.KOptions.getIntegerOption(KOption)*; # *org.apache.kerby.KOptions.getBooleanOption(KOption)* has Boolean return type and returns explicit null; # Switch statement found in *org.apache.kerby.util.Base64.decode(byte[], int, int)* where default case is missing; # Switch statement found in *org.apache.kerby.util.Base64.encode(byte[], int, int)* where default case is missing. > Fix findbugs Problem for lib module > ----------------------------------- > > Key: DIRKRB-353 > URL: https://issues.apache.org/jira/browse/DIRKRB-353 > Project: Directory Kerberos > Issue Type: Sub-task > Reporter: Xu Yaning > > For lib module, findbugs reports 10 problems to fix: > # Found reliance on default encoding in *org.apache.kerby.config.IniConfigLoader.loadConfig(ConfigImpl, Resource)*: new java.io.InputStreamReader(InputStream); > # *org.apache.kerby.config.IniConfigLoader.loadConfig(ConfigImpl, Resource)* may fail to close stream; > # *org.apache.kerby.config.MapConfigLoader.loadConfig(ConfigImpl, Resource)* makes inefficient use of keySet iterator instead of entrySet iterator; > # instanceof will always return true for all non-null values in *org.apache.kerby.config.PropertiesConfigLoader.loadConfig(ConfigImpl, Properties)*, since all String are instances of String; > # new *org.apache.kerby.config.Resource(String, File, Resource$Format)* may fail to clean up java.io.InputStream; > # Redundant nullcheck of name, which is known to be non-null in *org.apache.kerby.config.XmlConfigLoader.loadConfig(ConfigImpl, Element)*; > # Boxing/unboxing to parse a primitive *org.apache.kerby.KOptions.getIntegerOption(KOption)*; > # *org.apache.kerby.KOptions.getBooleanOption(KOption)* has Boolean return type and returns explicit null; > # Switch statement found in *org.apache.kerby.util.Base64.decode(byte[], int, int)* where default case is missing; > # Switch statement found in *org.apache.kerby.util.Base64.encode(byte[], int, int)* where default case is missing. -- This message was sent by Atlassian JIRA (v6.3.4#6332)