directory-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jiajia Li (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (DIRKRB-349) Fix findbugs Problems for kerby-asn1 module
Date Wed, 15 Jul 2015 03:07:04 GMT

    [ https://issues.apache.org/jira/browse/DIRKRB-349?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14627450#comment-14627450
] 

Jiajia Li commented on DIRKRB-349:
----------------------------------

V2 looks fine to me. I've committed. Thanks Yaning and Lin.
commit 02ccc73544886cbae6fd94f08ab101bbee14f221
Author: plusplusjiajia <jiajia.li@intel.com>
Date:   Wed Jul 15 11:03:58 2015 +0800

    DIRKRB-349 Fix findbugs Problems for kerby-asn1 module. Contributed by Yaning.

> Fix findbugs Problems for kerby-asn1 module
> -------------------------------------------
>
>                 Key: DIRKRB-349
>                 URL: https://issues.apache.org/jira/browse/DIRKRB-349
>             Project: Directory Kerberos
>          Issue Type: Sub-task
>            Reporter: Xu Yaning
>            Assignee: Xu Yaning
>         Attachments: DIRKRB-349-v1.patch, DIRKRB-349-v2.patch
>
>
> -<file classname="org.apache.kerby.asn1.type.AbstractAsn1Type">
> <BugInstance lineNumber="447" message="Bad comparison of nonnegative value with 0
in org.apache.kerby.asn1.type.AbstractAsn1Type.readLength(LimitedByteBuffer)" category="CORRECTNESS"
priority="Normal" type="INT_BAD_COMPARISON_WITH_NONNEGATIVE_VALUE"/>
> </file>
> -<file classname="org.apache.kerby.asn1.type.Asn1BmpString">
> <BugInstance lineNumber="30" message="Non-virtual method call in new org.apache.kerby.asn1.type.Asn1BmpString()
passes null for non-null parameter of new Asn1Simple(UniversalTag)" category="CORRECTNESS"
priority="High" type="NP_NULL_PARAM_DEREF_NONVIRTUAL"/>
> </file>
> -<file classname="org.apache.kerby.asn1.type.Asn1Choice">
> <BugInstance lineNumber="38" message="new org.apache.kerby.asn1.type.Asn1Choice(Asn1FieldInfo[])
may expose internal representation by storing an externally mutable object into Asn1Choice.fieldInfos"
category="MALICIOUS_CODE" priority="Normal" type="EI_EXPOSE_REP2"/>
> </file>
> -<file classname="org.apache.kerby.asn1.type.Asn1Collection">
> <BugInstance lineNumber="85" message="instanceof will always return true for all non-null
values in org.apache.kerby.asn1.type.Asn1Collection.decodeBody(LimitedByteBuffer), since all
org.apache.kerby.asn1.type.Asn1Item are instances of org.apache.kerby.asn1.type.Asn1Item"
category="STYLE" priority="Normal" type="BC_VACUOUS_INSTANCEOF"/>
> </file>
> -<file classname="org.apache.kerby.asn1.type.Asn1CollectionType">
> <BugInstance lineNumber="39" message="new org.apache.kerby.asn1.type.Asn1CollectionType(int,
Asn1FieldInfo[]) may expose internal representation by storing an externally mutable object
into Asn1CollectionType.fieldInfos" category="MALICIOUS_CODE" priority="Normal" type="EI_EXPOSE_REP2"/>
> </file>



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message