directory-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Liqi Yi (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (DIRKRB-265) Fix issues in Kerby-kerb Common module
Date Fri, 05 Jun 2015 09:19:01 GMT

    [ https://issues.apache.org/jira/browse/DIRKRB-265?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14574180#comment-14574180
] 

Liqi Yi commented on DIRKRB-265:
--------------------------------

There are several cases where the internal representation of a static final field is returned,
for example: 
In TgtPreauthMeta.java, PA_TYPES was defined as 
    private static final PaDataType[] PA_TYPES = new PaDataType[] {
            PaDataType.TGS_REQ
};
And then PA_TYPES was returned by function getPaTypes(). This type of use was reported as
“may expose internal representation”. If the SecurityManager works, the field PA_TYPES
won’t be modified. Do we want to create a copy of PA_TYPES and return that instead? 


> Fix issues in Kerby-kerb Common module
> --------------------------------------
>
>                 Key: DIRKRB-265
>                 URL: https://issues.apache.org/jira/browse/DIRKRB-265
>             Project: Directory Kerberos
>          Issue Type: Bug
>            Reporter: Jiajia Li
>            Assignee: Liqi Yi
>         Attachments: DIRKRB-265.001.patch
>
>
> https://analysis.apache.org/component_issues/index?id=org.apache.kerby%3Akerby-all#resolved=false|moduleUuids=74f247b6-9b3f-4687-aa7e-30f782552bd9



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message