Return-Path: X-Original-To: apmail-directory-dev-archive@www.apache.org Delivered-To: apmail-directory-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id AB8B018557 for ; Tue, 26 May 2015 10:12:23 +0000 (UTC) Received: (qmail 69261 invoked by uid 500); 26 May 2015 10:12:17 -0000 Delivered-To: apmail-directory-dev-archive@directory.apache.org Received: (qmail 69196 invoked by uid 500); 26 May 2015 10:12:17 -0000 Mailing-List: contact dev-help@directory.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: "Apache Directory Developers List" Delivered-To: mailing list dev@directory.apache.org Received: (qmail 69179 invoked by uid 99); 26 May 2015 10:12:17 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 26 May 2015 10:12:17 +0000 Date: Tue, 26 May 2015 10:12:17 +0000 (UTC) From: "Paul Richardson (JIRA)" To: dev@directory.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Updated] (DIRSTUDIO-1047) No BrowserViewUniversalListener.connectionOpened null checks MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/DIRSTUDIO-1047?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Paul Richardson updated DIRSTUDIO-1047: --------------------------------------- Attachment: safeguard-browser-connections.diff Patch for safeguarding browser connections when a connection event is fired. I have checked all the iimplementations of ConnectionUpdateListener and the patch addresses those that might have an issue. > No BrowserViewUniversalListener.connectionOpened null checks > ------------------------------------------------------------ > > Key: DIRSTUDIO-1047 > URL: https://issues.apache.org/jira/browse/DIRSTUDIO-1047 > Project: Directory Studio > Issue Type: Bug > Components: studio-ldapbrowser > Affects Versions: 2.0.0-M8 (2.0.0.v20130628) > Reporter: Paul Richardson > Fix For: 2.0.0-M9 > > Attachments: safeguard-browser-connections.diff > > > BrowserViewUniversalListener.connectionOpened is fired on the opening of a connection. In my case, the connection being opened comes from a wizard displaying the BrowserWidget rather than the BrowserView. In this use-case, the BrowserConnection used in the wizard is only temporary so not added to the BrowserCorePlugin ConnectionManager. > Consequently, opening a connection in the wizard while the BrowserView is also open, the latter's BrowserViewUniversalListener.connectionOpened() is fired and a NPE results. > A check can be added to assert that the BrowserConnection fetched from the ConnectionManager is not null. Only if not null should the BrowserView viewer be refreshed. -- This message was sent by Atlassian JIRA (v6.3.4#6332)