directory-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Paul Richardson (JIRA)" <>
Subject [jira] [Updated] (DIRSTUDIO-1047) No BrowserViewUniversalListener.connectionOpened null checks
Date Tue, 26 May 2015 10:12:17 GMT


Paul Richardson updated DIRSTUDIO-1047:
    Attachment: safeguard-browser-connections.diff

Patch for safeguarding browser connections when a connection event is fired.

I have checked all the iimplementations of ConnectionUpdateListener and the patch addresses
those that might have an issue.

> No BrowserViewUniversalListener.connectionOpened null checks
> ------------------------------------------------------------
>                 Key: DIRSTUDIO-1047
>                 URL:
>             Project: Directory Studio
>          Issue Type: Bug
>          Components: studio-ldapbrowser
>    Affects Versions: 2.0.0-M8 (2.0.0.v20130628)
>            Reporter: Paul Richardson
>             Fix For: 2.0.0-M9
>         Attachments: safeguard-browser-connections.diff
> BrowserViewUniversalListener.connectionOpened is fired on the opening of a connection.
In my case, the connection being opened comes from a wizard displaying the BrowserWidget rather
than the BrowserView. In this use-case, the BrowserConnection used in the wizard is only temporary
so not added to the BrowserCorePlugin ConnectionManager.
> Consequently, opening a connection in the wizard while the BrowserView is also open,
the latter's BrowserViewUniversalListener.connectionOpened() is fired and a NPE results.
> A check can be added to assert that the BrowserConnection fetched from the ConnectionManager
is not null. Only if not null should the BrowserView viewer be refreshed.

This message was sent by Atlassian JIRA

View raw message