directory-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Emmanuel Lécharny <elecha...@gmail.com>
Subject Re: svn commit: r1681745 - /directory/shared/trunk/ldap/client/api/src/main/java/org/apache/directory/ldap/client/api/LdapNetworkConnection.java
Date Wed, 27 May 2015 21:47:23 GMT
Le 27/05/15 23:01, Stefan Seelmann a écrit :
> On 05/27/2015 11:44 AM, Kiran Ayyagari wrote:
>> On Wed, May 27, 2015 at 5:36 PM, Radovan Semancik <
>>> Well, it looks like it is covered by some tests as they have failed in
>>> Jenkins:
>>> https://builds.apache.org/job/dir-apacheds-ubuntu-deploy/1718/org.apache.directory.server$ldap-client-test/
>>>
>>> So, my question is how can I run these tests on my machine before a commit?
>>>
>>> I'm still new here so I'm trying to learn the development process that you
>>> are usually following. What tests are you usually running before commit? Do
>>> you run something else than "mvn clean install"? Or do you just run "mvn
>>> clean install", commit and then check Jenkins after the commit?
>>>
>> just mvn clean install
>>
>> otoh, I see why it wasn't failed when you ran the tests, the API
>> integration tests are in ldap-client-test module
>> you should run mvn clean install there as well after modifying client.
>>
>> A general rule we all follow is to build the whole server after any change,
>> that way the whole integration
>> test suite gets executed
> Yes, it is a bit unfortune that the integration tests of the LDAP API
> resist in the ApacheDS project. We discussed that multiple times before,
> but always came to the conclusion to keep them there.

We could have created a separate projects for those tests, but that
would have meant some more complexity. And we didn't want to have them
being part of the LDAP API, because then that would mean the LDAP API
would depend on ApacheDS, which depends on the API...



Mime
View raw message