directory-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Stefan Seelmann <>
Subject Re: $NON-NLS-1$ usage...
Date Mon, 04 May 2015 17:30:50 GMT
On 05/04/2015 02:37 PM, Emmanuel L├ęcharny wrote:
> Hi guys,
> in Studio, we have thousands of "// $NON-NLS-1$" comments in Studio's
> code. Those comments were used to shut down some warnings in eclipse.
> This is now totally superflouous, as we already have ignored such a
> warning in the formatter we are using.
> I woudl suggest we remove all those comments in the code.
> Thoughts ?

They have another meaning: They are marker of the "Externalize Strings"
tool/wizard. So if we want to continue to support NLS I think usage of
the tool and the markers are essential.

Kind Regards,

View raw message