directory-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Lin Chen (JIRA)" <j...@apache.org>
Subject [jira] [Comment Edited] (DIRKRB-205) Adding the identity to zookeeper backend
Date Fri, 03 Apr 2015 08:43:52 GMT

    [ https://issues.apache.org/jira/browse/DIRKRB-205?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14394173#comment-14394173
] 

Lin Chen edited comment on DIRKRB-205 at 4/3/15 8:43 AM:
---------------------------------------------------------

Hi Jiajia,
    Thanks for your working on this. The work looks great. Some questions:

    1. Should we add not-yet-commons-ssl dependency? I remove it and compile successfully.

    2. According to the patch, if my understanding is correct, when we add a new identity
to the backend, we need set identity name first to create a zkNode for the idnetity. Maybe
we'd better not to depend on the interface calling order to ensure the correctness. Is is
better to make a new class, for example {{IdentityZNode}}, which has a constructor with pricipal
parameter? That can ensure {{setIdentityName}} in the first place. Below is an example about
{{IdentityZNode}}:
{code}
public class IdentityZNode {
    priavte String identityName;
    public IdentityZNode(String identityName) {
            this.identityName = identityName;
            ZKUtil.createWithParents(....);
    }

    public void setPrincipalName(String principalName) {...}

    public void setCreatedTime(KerberosTime time) {...}

    ....
}
{code}
What do you think about this?

    3. Are some methods in {{KerbyZNode}} like {{getPrincipalNameZnode}}, {{getKeyVersionZNode}}
used on the class only? Is it better to make them to be private?

    I am not very familiar with zookeeper. If something is not correct, please forgive me.


was (Author: hazelc):
Hi Jiajia,
    Thanks for your working on this. The work looks great. Some questions:

    1. Should we add not-yet-commons-ssl dependency? I remove it and compile successfully.

    2. According to the patch, if my understanding is correct, when we add a new identity
to the backend, we need set principal first to create a zkNode for the idnetity. Maybe we'd
better not to depend on the interface calling order to ensure the correctness. Is is better
to make a new class, for example {{IdentityZNode}}, which has a constructor with pricipal
parameter? That can ensure {{setPrincipal}} in the first place. Below is an example about
{{IdentityZNode}}:
{code}
public class IdentityZNode {
    public IdentityZNode(String principalName) {
            ZKUtil.createWithParents(....);
    }

    public void setKeyVersion(...) {...}

    public void setKdcFlags(...) {...}

    ....
}
{code}
What do you think about this?

    3. Are some methods in {{KerbyZNode}} like {{getPrincipalNameZnode}}, {{getKeyVersionZNode}}
used on the class only? Is it better to make them to be private?

    I am not very familiar with zookeeper. If something is not correct, please forgive me.

> Adding the identity to zookeeper backend
> ----------------------------------------
>
>                 Key: DIRKRB-205
>                 URL: https://issues.apache.org/jira/browse/DIRKRB-205
>             Project: Directory Kerberos
>          Issue Type: New Feature
>            Reporter: Jiajia Li
>            Assignee: Jiajia Li
>         Attachments: DIRKRB-205-V1.patch, DIRKRB-205-V2.patch
>
>
> Implementing the feature of adding the identity to zookeeper backend.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message