Return-Path: X-Original-To: apmail-directory-dev-archive@www.apache.org Delivered-To: apmail-directory-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 91DA5178F2 for ; Tue, 20 Jan 2015 05:52:32 +0000 (UTC) Received: (qmail 37132 invoked by uid 500); 20 Jan 2015 05:52:34 -0000 Delivered-To: apmail-directory-dev-archive@directory.apache.org Received: (qmail 37077 invoked by uid 500); 20 Jan 2015 05:52:34 -0000 Mailing-List: contact dev-help@directory.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: "Apache Directory Developers List" Delivered-To: mailing list dev@directory.apache.org Received: (qmail 37067 invoked by uid 99); 20 Jan 2015 05:52:34 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 20 Jan 2015 05:52:34 +0000 Date: Tue, 20 Jan 2015 05:52:34 +0000 (UTC) From: "Kai Zheng (JIRA)" To: dev@directory.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (DIRKRB-140) Section supports in Configuration MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/DIRKRB-140?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14283439#comment-14283439 ] Kai Zheng commented on DIRKRB-140: ---------------------------------- Hi Lin, The change looks great. Some minor comments: 1. Could we add some comments for the test asserts to make them more clear; 2. Better to use more meaningful test values. > Section supports in Configuration > --------------------------------- > > Key: DIRKRB-140 > URL: https://issues.apache.org/jira/browse/DIRKRB-140 > Project: Directory Kerberos > Issue Type: Sub-task > Reporter: Lin Chen > Assignee: Lin Chen > Attachments: DIRKRB-140_v1.patch > > > In MIT Kerberos configuration file, there are many sections. For example, > {code} > [libdefaults] > default_realm = EXAMPLE.COM > dns_lookup_realm = false > [logging] > default = FILE:/var/log/krb5libs.log > kdc = FILE:/var/log/krb5kdc.log > [kdcdefaults] > kdc_ports = 88 > kdc_tcp_ports = 8014 > {code} > [libdefaults], [logging], [kdcdefaults] and configs below them are sections. Base on the section supports, it will be easy to support MIT Kerberos configuration format. -- This message was sent by Atlassian JIRA (v6.3.4#6332)