directory-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Emmanuel Lecharny (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (DIRKRB-120) Enhance KDC Server to respect kdc.conf file
Date Thu, 15 Jan 2015 09:41:34 GMT

    [ https://issues.apache.org/jira/browse/DIRKRB-120?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14278493#comment-14278493
] 

Emmanuel Lecharny commented on DIRKRB-120:
------------------------------------------

It's not going to fly. There are several things that is not good in this path :

- total lack of Javadoc. Keep in mind that this could will have to be maintained, and this
goes with documentation.
- things like :

{code}
+    Assert.assertEquals(krbConfig.getDefaultLoggingLocation(), "FILE:/var/log/krb5libs.log");
{code}

are not acceptable if we are targetting the main platforms the server is likely to run. One
of them being a minor OS, but used by 90% of the companies : Windows.

Instead of proposing patches that enforce a specific platform, I'd rather see a discussion
about what is the impact of setting such config value, and how we can make it work on any
platform.

- Last, not least, I have no idea what this issue is about. Where does the current code is
wrong, and what needs to be fixed ? I'd like to see a clear description on what need to be
done, and why it needs to be done.

Thanks !

> Enhance KDC Server to respect kdc.conf file
> -------------------------------------------
>
>                 Key: DIRKRB-120
>                 URL: https://issues.apache.org/jira/browse/DIRKRB-120
>             Project: Directory Kerberos
>          Issue Type: Sub-task
>            Reporter: Lin Chen
>            Assignee: Emmanuel Lecharny
>         Attachments: DIRKRB-120_v1.patch
>
>
> Enhance KDC Server to respect kdc.conf file to make administration easier.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message