directory-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Zheng, Kai" <>
Subject RE: [kerby/haox] Dependencies updates needed
Date Mon, 12 Jan 2015 14:34:14 GMT
Hi Emmanuel,

I have merged your changes into the master, and refactored a little bit. Please let me know
if anything I missed. Thanks.


-----Original Message-----
From: Zheng, Kai [] 
Sent: Monday, January 12, 2015 4:58 PM
To: Apache Directory Developers List
Subject: RE: [kerby/haox] Dependencies updates needed

Hi Emmanuel,

I have checked the great changes in the new branch. Would you mind I make some slight adjustment
to make the style consistent with the existing codes before I merge them in? Thanks.

About the test splitting, there're quite a few other cases like the one you changed. I agree
with your approach. Would like more help from other contributors to get them done also. Will
ask for help from new contributors.


-----Original Message-----
From: Emmanuel Lécharny []
Sent: Monday, January 12, 2015 4:01 PM
To: Apache Directory Developers List
Subject: Re: [kerby/haox] Dependencies updates needed

Le 12/01/15 04:15, Zheng, Kai a écrit :
> Hi Emmanuel,
>>> I just check for the dependencies use by Kerby/Haox, there are a few 
>>> that require to be bumped up
> Thanks for taking care of this. What tasks are involved here?

Atm, I have created a branch (maven-refactor) in which I have updated the deps. Feel free
to check it and merge it back to master if it's ok.

I also have injected an updated test class, where I split the various tests into atomic ones,
to better see what are the failing tests, "à la"
Junit way, instead of having one single test running all the test cases.
I also added the missing Apache header and javadoc, so that the class is now compliant with
hat we should have for all the project's classes (don't expect such a task to be funny, but
we have to go through this class after the other, in the coming weeks).

Thanks !

View raw message