directory-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Emmanuel Lecharny (JIRA)" <>
Subject [jira] [Commented] (FC-52) Use enum instead of static int for errors
Date Sun, 21 Dec 2014 19:52:13 GMT


Emmanuel Lecharny commented on FC-52:

For instance, the {{ObjectFactory().createWarning}} method take a {{int}} as a parameter,
and it's used with error ID from {{GlobalPwMsgIds}} and {{GlobalErrIds}}. We have to fix that.

> Use enum instead of static int for errors
> -----------------------------------------
>                 Key: FC-52
>                 URL:
>             Project: FORTRESS
>          Issue Type: Task
>    Affects Versions: 1.0.0-RC39
>            Reporter: Emmanuel Lecharny
> We have a few classes that are used to store the error we use in Fortress :
> * GlobalErrIds
> * EErrIds
> * GlobalPwMsgIds
> Those classes declare errors ID using public static final int. The idea is to use enum
as a replacement.
> Technically, it's a no brainer, except that a few oddities have to be handled :
> - first, we should decide if we should keep the numbering. With enum, it's not mandatory,
as it's done automatically.
> - If so, we should decide if the Exception should take a number of an instance of one
of the enum. It would be good to be able to use the enums, but we have to check that some
of the exeption aren't receiving ID fro one of the existing class.
> - If there are some collisions, then either we define an interface tha every enum should
implement, but we will have to be sure that the ID number - if we define them explicitely
- aren't colliding.
> - Serialization must be handled to. It should not be a real issue though.
> All in all, it's a 2 hours work once we have decided the path we should follow regarding
those few points

This message was sent by Atlassian JIRA

View raw message