directory-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Colm O hEigeartaigh (JIRA)" <>
Subject [jira] [Updated] (DIRSERVER-2031) Use a properly random port when creating a KDCServer via annotation
Date Tue, 16 Dec 2014 11:02:13 GMT


Colm O hEigeartaigh updated DIRSERVER-2031:
    Attachment: dirserver-2031.patch.2

Hi Emmanuel,

Please see attached for a revised patch for this issue.

The previous patch did actually use a port if provided in the annotation. It just didn't use
the "startPort" parameter that was passed through to the getKdcServer method in ServerAnnotationProcessor.
This port was only used as a starting port to find a free port, if no port was specified in
the annotation (and was hard-coded as 1024 in calling code). As we are generating a random
port in this scenario now, the parameter is no longer required.

I've added two new protocols as you have outlined, "KRB" and "CPW". When these protocols are
used we generate both UDP + TCP transports on either the port provided, or using a random
port if not provided. It makes the code a lot simpler compared to the previous patch.



> Use a properly random port when creating a KDCServer via annotation
> -------------------------------------------------------------------
>                 Key: DIRSERVER-2031
>                 URL:
>             Project: Directory ApacheDS
>          Issue Type: Improvement
>            Reporter: Colm O hEigeartaigh
>            Assignee: Emmanuel Lecharny
>            Priority: Minor
>             Fix For: 2.0.0-M20
>         Attachments: dirserver-2031.patch, dirserver-2031.patch.2
> Currently, when creating a KDCServer via annotation, the "random" port is always "1024".
In addition, it should be possible to share the same random port for multiple transports.

This message was sent by Atlassian JIRA

View raw message