directory-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Stefan Seelmann (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (DIRSTUDIO-1002) New value editors for eDirectory
Date Sun, 07 Dec 2014 21:35:13 GMT

    [ https://issues.apache.org/jira/browse/DIRSTUDIO-1002?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14237282#comment-14237282
] 

Stefan Seelmann commented on DIRSTUDIO-1002:
--------------------------------------------

I tested the value editors (due to lack of access to an eDirectory I assigned the value editors
to other attributes) and reviewed the code. Overall looks good and I think it would be a good
addition to the main Studio distribution and I'd recommend the addition.

Let me list some issues and TODOs:

1. Plugin project: I'd recommend to have a separate plugin for eDirectory related stuff, proposed
name 'org.apache.directory.studio.edirectory'. This plugin needs to be included into our build
system. We are currently migrating our build system to Tycho, this is done in branch https://svn.apache.org/repos/asf/directory/studio/branches/studio-tycho.
I think it makes sense to create the new plugin just there.

Are you (or want to become) familiar with Maven Tycho and do you have time to setup the base
plugin structure and attach it as patch? Otherwise I can create it.


2. Package names: I'd recommend to use 'org.apache.directory.studio.edirectory' as root package
name (same as plugin name)


3. Coding standards: Please see https://directory.apache.org/apacheds/coding-standards.html,
formatting rules and code templates can be found there. Most important points:
    * Apache license header is required
    * @author tag needs to be changed
    * 4 spaces no tabs

4. It would be great if you could make the required changes. When done it would be nice if
you can attach the code (source only) in patch format. 


5. As this is not only a small contribution some legal paperwork (ICLA, CCLA) need to be done,
but I think you already started.


> New value editors for eDirectory
> --------------------------------
>
>                 Key: DIRSTUDIO-1002
>                 URL: https://issues.apache.org/jira/browse/DIRSTUDIO-1002
>             Project: Directory Studio
>          Issue Type: New Feature
>          Components: studio-ldapbrowser
>         Environment: org.apache.directory.studio.valueeditors extension point
>            Reporter: Mark van Reijn
>              Labels: edirectory, editor, value
>         Attachments: nl.idfocus.apacheds.studio.valueeditors.jar
>
>
> I have developed a set of value editors specific to Novell / NetIQ eDirectory and Identity
Manager. 
> In particular the ACL editor and Path editor are helpful for eDirectory users since they
are composite values which are hard to edit using string editors. 
> Attached is a JAR file with the editors including the source. This JAR can be added to
the plugins directory for testing. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message