directory-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Emmanuel L├ęcharny <elecha...@gmail.com>
Subject Re: [Studio] Changes in the Ldap configuration plugin, first pass.
Date Wed, 03 Dec 2014 19:07:45 GMT
Ok, some heads-up...

(I can't commit anything, the ASF SVN server is down).

I have changed my mind a bit, and left the Overview page as it was before.

The Ldap/Ldaps page will allow the modification of the Transport
parameters :

o address (default to 0.0.0.0)
o nbThreads (default to 8)
o backlog size (default to 50)

This is currently working for LDAP and LDAPS.

LDAPS transport wikll have slightly more parameters :
o enabled cipher suite (already there)
o enabled protocol (to be added)
o needClientAuth
o wantClientAuth

The screen will looks like :

 +------------------------------------+
 | .--------------------------------. |
 | |V LDAP Transport                | |
 | +--------------------------------| |
 | | [X] Enabled                    | |
 | |  Address  : [////////////////] | |
 | |  Port     : [/////////]        | |
 | |  nbThreads: [/////////]        | |
 | |  backLog  : [/////////]        | |
 | +--------------------------------+ |
 | .--------------------------------. |
 | |V LDAPS Transport               | |
 | +--------------------------------| |
 | | [X] Enabled                    | |
 | |  Address  : [////////////////] | |
 | |  Port     : [/////////]        | |
 | |  nbThreads: [/////////]        | |
 | |  backLog  : [/////////]        | |
 | |  Cipher suite :                | |
 | |   +-----------------+          | |
 | |   |                 | (add)    | |
 | |   |                 | (edit)   | |
 | |   |                 | (delete) | |
 | |   +-----------------+          | |
 | |  Enabled protocols :           | |
 | |   +-----------------+          | |
 | |   |                 | (add)    | |
 | |   |                 | (edit)   | |
 | |   |                 | (delete) | |
 | |   +-----------------+          | |
 | |  [X] needClientAuth            | |
 | |  [X] wantClientAuth            | |
 | +--------------------------------| |

At this point, I may make the LDAP and LDAPS transport sections COMPACT
instead of EXPANDED by default (or add a section for optional LDAPS
parameters).

One other thing I'll do is to check the values somhow differently.
Currently, we throw a hell of NumberFoirmatException like :


java.lang.NumberFormatException: For input string: "A"
    at
java.lang.NumberFormatException.forInputString(NumberFormatException.java:65)
    at java.lang.Integer.parseInt(Integer.java:580)
    at java.lang.Integer.parseInt(Integer.java:615)
    at
org.apache.directory.studio.apacheds.configuration.v2.editor.LdapLdapsServersPage$4.modifyText(LdapLdapsServersPage.java:284)
    at
org.eclipse.swt.widgets.TypedListener.handleEvent(TypedListener.java:179)
    at org.eclipse.swt.widgets.EventTable.sendEvent(EventTable.java:84)
    at org.eclipse.swt.widgets.Display.sendEvent(Display.java:4188)
    at org.eclipse.swt.widgets.Widget.sendEvent(Widget.java:1467)
    at org.eclipse.swt.widgets.Widget.sendEvent(Widget.java:1490)
    at org.eclipse.swt.widgets.Widget.sendEvent(Widget.java:1475)
    at org.eclipse.swt.widgets.Widget.notifyListeners(Widget.java:1279)

I'd rather change the color of the text to red to inform the user that
the input is incorrect. I already did that for the Address, it's kind of
cool.

I'm definitively making progress, and have a bit of fun in an area I
haven't played with lately !


Any feedback welcome, of course.


Mime
View raw message