directory-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Emmanuel Lécharny <elecha...@gmail.com>
Subject Re: directory-fortress-core git commit: rolled back change to OrgUnitDao add - remove global constant - broke ARBAC checkAccess due to incorrect format of method name.
Date Sun, 09 Nov 2014 07:54:55 GMT
Doh...

it should be :

    private static final String ADD_OU_METHOD = "addOU";
    private static final String FULL_ADD_OU_METHOD = CLS_NM + "." + ADD_OU_METHOD;


There are two dots with my previous change.

Le 07/11/14 21:39, smckinney@apache.org a écrit :
> Repository: directory-fortress-core
> Updated Branches:
>   refs/heads/master 4e1c9b38d -> 43d4a2387
>
>
> rolled back change to OrgUnitDao add - remove global constant - broke ARBAC checkAccess
due to incorrect format of method name.
>
>
> Project: http://git-wip-us.apache.org/repos/asf/directory-fortress-core/repo
> Commit: http://git-wip-us.apache.org/repos/asf/directory-fortress-core/commit/43d4a238
> Tree: http://git-wip-us.apache.org/repos/asf/directory-fortress-core/tree/43d4a238
> Diff: http://git-wip-us.apache.org/repos/asf/directory-fortress-core/diff/43d4a238
>
> Branch: refs/heads/master
> Commit: 43d4a23872cb4d348fed74f33146dfc757164d26
> Parents: 4e1c9b3
> Author: Shawn McKinney <smckinney@apache.org>
> Authored: Fri Nov 7 14:39:00 2014 -0600
> Committer: Shawn McKinney <smckinney@apache.org>
> Committed: Fri Nov 7 14:39:00 2014 -0600
>
> ----------------------------------------------------------------------
>  .../directory/fortress/core/rbac/DelAdminMgrImpl.java   | 12 +++++-------
>  1 file changed, 5 insertions(+), 7 deletions(-)
> ----------------------------------------------------------------------
>
>
> http://git-wip-us.apache.org/repos/asf/directory-fortress-core/blob/43d4a238/src/main/java/org/apache/directory/fortress/core/rbac/DelAdminMgrImpl.java
> ----------------------------------------------------------------------
> diff --git a/src/main/java/org/apache/directory/fortress/core/rbac/DelAdminMgrImpl.java
b/src/main/java/org/apache/directory/fortress/core/rbac/DelAdminMgrImpl.java
> index ab6f3a3..43c8a09 100755
> --- a/src/main/java/org/apache/directory/fortress/core/rbac/DelAdminMgrImpl.java
> +++ b/src/main/java/org/apache/directory/fortress/core/rbac/DelAdminMgrImpl.java
> @@ -51,8 +51,6 @@ import java.util.Set;
>  public final class DelAdminMgrImpl extends Manageable implements DelAdminMgr
>  {
>      private static final String CLS_NM = DelAdminMgrImpl.class.getName();
> -    private static final String ADD_OU_METHOD = ".addOU";
> -    private static final String FULL_ADD_OU_METHOD = CLS_NM + "." + ADD_OU_METHOD;
>      private static final OrgUnitP ouP = new OrgUnitP();
>      private static final AdminRoleP admRP = new AdminRoleP();
>      private static final PermP permP = new PermP();
> @@ -339,11 +337,11 @@ public final class DelAdminMgrImpl extends Manageable implements
DelAdminMgr
>      @Override
>      public OrgUnit add(OrgUnit entity) throws SecurityException
>      {
> -        assertContext( ADD_OU_METHOD, entity, GlobalErrIds.ORG_NULL );
> -        setEntitySession( CLS_NM, ADD_OU_METHOD, entity);
> -        VUtil.assertNotNull( entity.getType(), GlobalErrIds.ORG_TYPE_NULL, FULL_ADD_OU_METHOD
);
> -        
> -        return ouP.add( entity );
> +        String methodName = "addOU";
> +        assertContext(CLS_NM, methodName, entity, GlobalErrIds.ORG_NULL);
> +        setEntitySession(CLS_NM, methodName, entity);
> +        VUtil.assertNotNull(entity.getType(), GlobalErrIds.ORG_TYPE_NULL, CLS_NM + "."
+ methodName);
> +        return ouP.add(entity);
>      }
>  
>      /**
>


Mime
View raw message