directory-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Emmanuel L├ęcharny <elecha...@gmail.com>
Subject [Fortress] Code smell...
Date Thu, 06 Nov 2014 16:37:26 GMT
Hi Shawn,

there is one method in CommandLineInterpreter, printPermission, which
contains a line of code that I found fishy :


                LOG.info(type + "   KEY" + ++ctr + " [" + key + "]");

Note the ++ctr here.

That means if we remove the LOG, the ctr counter will not be incremented.

Do you agree that we should move the ++ctr out of this LOG statement ?

Thanks !


Mime
View raw message